Review Request 111686: KPluginFactory macros port

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111686/#review36497
-----------------------------------------------------------



staging/kservice/src/plugin/kpluginfactory.h
<http://git.reviewboard.kde.org/r/111686/#comment26932>

    Does this really expand the macro within the string? I kind of doubt that. You probably want to remove the double-quotes, no?



staging/kservice/src/plugin/kpluginfactory.h
<http://git.reviewboard.kde.org/r/111686/#comment26933>

     ... const;
    
    Documentation?
    
    including @since 5.0



staging/kservice/src/plugin/kpluginloader.cpp
<http://git.reviewboard.kde.org/r/111686/#comment26938>

    This relates to my comment in the other review. If what we have is a list with always just one parameter (which is a map), why not pass the map directly in setArgs, rather than a list of maps with one map in the list?
    
    IOW:  setArgs(QVariantMap).


- David Faure


On July 25, 2013, 4:10 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111686/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 4:10 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Make K_EXPORT_PLUGIN work with Qt's new plugin system
> 
> This patch changes the K_EXPORT_MACRO and the class it generates to be compatible with Qt's new plugin / metadata system. It basically replaces the old macros around q_plugin_instance with the new ones, using Q_INTERFACES. There's also a setter for the args, which are used to pass metadata into the plugin.
> 
> Otherwise, this is the minimal change, to make old plugin factories work atop the new framework.
> 
> This change is source-compatible, but the right .moc file when this macro is used from the .cpp file.
> 
> 
> Diffs
> -----
> 
>   staging/kservice/src/plugin/kexportplugin.h cc5d58b 
>   staging/kservice/src/plugin/kpluginfactory.h a5ea21b 
>   staging/kservice/src/plugin/kpluginfactory.cpp 6bd2350 
>   staging/kservice/src/plugin/kpluginfactory_p.h 09fcfe4 
>   staging/kservice/src/plugin/kpluginloader.cpp 945c75b 
> 
> Diff: http://git.reviewboard.kde.org/r/111686/diff/
> 
> 
> Testing
> -------
> 
> Loaded plugins using KService, KPluginLoader, QPluginLoader and Plasma::PluginLoader, all work as expected.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130725/589e7e0f/attachment-0001.html>