Review Request 111649: Prevent linking to Qt4 by providing a FindDBusMenuQt5.cmake file

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111649/#review36495
-----------------------------------------------------------

Ship it!


Looks good as far as I see.


- Alexander Neundorf


On July 25, 2013, 6:40 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111649/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 6:40 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Prevent linking to Qt4 by providing a FindDBusMenuQt5.cmake file
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c2f3cfcc84553a89992ff7cdd56bb3cf7a319661 
>   cmake/modules/CMakeLists.txt f0a645019405a46ccea6a86f686f5dd9b71d285e 
>   cmake/modules/FindDBusMenuQt.cmake c231aeac0fe118577fbd57e83320f59c6e6cc23d 
>   cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION 
>   kdeui/CMakeLists.txt 6295988bc42fc91eb7e27f737dd7dcadf6ae14c8 
>   staging/knotifications/src/CMakeLists.txt cfaa38a88e20f8a87b0dbd13217521bc46dfa993 
> 
> Diff: http://git.reviewboard.kde.org/r/111649/diff/
> 
> 
> Testing
> -------
> 
> kdelibs no longer links to system dbusmenu-qt
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130725/ae784572/attachment.html>