Review Request 111644: Delete included kde_file.h actually not used

[Kevin Ottens]

> On July 22, 2013, 8:42 p.m., David Faure wrote:
> > Trivial enough. If it builds, it's correct.
> 
> Kevin Ottens wrote:
>     That said, it needs 111636 to be in first.
> 
> David Gil Oliva wrote:
>     Kevin, I'm surprised, I don't see the connection with #111636. I have written this patch because I wanted to clean up the task and only leave the classes which actually use kde_file.h, in order to concentrate better.
>     
>     Nevertheless, I don't ship it until you say so.
> 
> Kevin Ottens wrote:
>     Well, 111636 remove one use of kde_file.h. So you can't remove kde_file.h itself (as this patch does) before it's really unused. :-)
> 
> David Gil Oliva wrote:
>     Kevin, my description of this patch must be horrible, because it doesn't remove kde_file.h itself, but some #include <kde_file.h> that weren't actually used in the code of http.cpp, kruntest.cpp and kfilewidget.cpp.
>     
>     Please reconsider letting me ship it.

Ah right, description doesn't match the patch... that plus me being stupid and falling the trap. ;-)
Feel free to push it indeed.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111644/#review36328
-----------------------------------------------------------


On July 22, 2013, 8:06 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111644/
> -----------------------------------------------------------
> 
> (Updated July 22, 2013, 8:06 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Delete included kde_file.h actually not used
> 
> Rewrite some includes in standard form
> 
> 
> Diffs
> -----
> 
>   kfile/kfilewidget.cpp 942c9a374b9434253e1f6fe6e8c0a498df3f5c8b 
>   kio/tests/kruntest.cpp d44519f79b64368279dc7ac8da1b898a97f8086b 
>   kioslave/http/http.cpp 262f719051caf8a5c8f10a61902a5ed0e88ba1b2 
> 
> Diff: http://git.reviewboard.kde.org/r/111644/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130724/39e725f7/attachment.html>