Review Request 111651: Move KCModule to KConfigWidgets

[Andrea Scarpino]

> On July 23, 2013, 8:52 p.m., Alexander Neundorf wrote:
> > By replacing the LIBRARIES variables with the target names this broke the standalone build of kconfigwidgets.
> > 
> >

I can replace it again, but I saw others modules do that. This should be fixed everywhere then, or I'm wrong?


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111651/#review36407
-----------------------------------------------------------


On July 23, 2013, 11:56 a.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111651/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 11:56 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> = subj
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt ded44e3 
>   kdeui/widgets/kcmodule.h 0d29267 
>   kdeui/widgets/kcmodule.cpp 78e0ae5 
>   staging/kconfigwidgets/src/CMakeLists.txt 52168ab 
> 
> Diff: http://git.reviewboard.kde.org/r/111651/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130723/65e9f131/attachment.html>