Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111649/#review36406
-----------------------------------------------------------


What's the current state of dbusmenuqt ?
Can it be built against both Qt4 and Qt5 ?
If so, do they have different version numbers then ?
I don't like that an old version of FindDBusMenuQt.cmake will find the Qt4 version, while a newer version of FindDBusMenuQt.cmake will find only the Qt5 version.
A simple solution would be to add a FindDBusMenuQt5.cmake. This would make it very obvious, and the "old" file would just keep working.

- Alexander Neundorf


On July 23, 2013, 11:16 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111649/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 11:16 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Prevent linking to Qt4 based DBusMenuQt
> 
> This fixes all sorts of weird crashes due to having an executable
> linked to both Qt4 and Qt5
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindDBusMenuQt.cmake c231aeac0fe118577fbd57e83320f59c6e6cc23d 
> 
> Diff: http://git.reviewboard.kde.org/r/111649/diff/
> 
> 
> Testing
> -------
> 
> kdelibs no longer links to system dbusmenu-qt
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130723/ac970848/attachment-0001.html>