Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

[Alexander Richardson]

> On July 23, 2013, 11:45 a.m., Kevin Ottens wrote:
> > cmake/modules/FindDBusMenuQt.cmake, line 45
> > <http://git.reviewboard.kde.org/r/111649/diff/1/?file=172963#file172963line45>
> >
> >     We probably want to bump the required minimum version to 0.9 instead of removing that block.

Not sure if my change setting DBusMenuQt_FIND_VERSION is correct, I have very little experience writing find modules.
When modifying the header to set the version to 0.8.9 DBusMenuQt is no longer found, so it seems to work.

Probably the best solution would be dbusmenu-qt providing a DBusMenuQtConfig.cmake file.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111649/#review36353
-----------------------------------------------------------


On July 23, 2013, 1:16 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111649/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 1:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Prevent linking to Qt4 based DBusMenuQt
> 
> This fixes all sorts of weird crashes due to having an executable
> linked to both Qt4 and Qt5
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindDBusMenuQt.cmake c231aeac0fe118577fbd57e83320f59c6e6cc23d 
> 
> Diff: http://git.reviewboard.kde.org/r/111649/diff/
> 
> 
> Testing
> -------
> 
> kdelibs no longer links to system dbusmenu-qt
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130723/27588a52/attachment.html>