Review Request 111605: move kfreediskspace to kde4support

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111605/#review36197
-----------------------------------------------------------



staging/kde4support/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111605/#comment26791>

    why not just move it into this section?
    This is the list of headers that were installed into INCLUDE_INSTALL_DIR directly.



staging/kde4support/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111605/#comment26794>

    this one was actually not installed by kde4, apparently, please remove the line.



staging/kde4support/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111605/#comment26792>

    this one was wrong too, kde4 installed it into INCLUDE_INSTALL_DIR



staging/kde4support/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111605/#comment26793>

    same here, move it up


- David Faure


On July 20, 2013, 3:10 a.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111605/
> -----------------------------------------------------------
> 
> (Updated July 20, 2013, 3:10 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> move kfreediskspace to kde4support
> 
> 
> Diffs
> -----
> 
>   kio/CMakeLists.txt 38032a0 
>   kio/kfile/kdiskfreespace.h fcaee8d 
>   kio/kfile/kdiskfreespace.cpp  
>   staging/kde4support/src/CMakeLists.txt 137ada2 
> 
> Diff: http://git.reviewboard.kde.org/r/111605/diff/
> 
> 
> Testing
> -------
> 
> it builds
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130720/c7863a45/attachment.html>