Review Request 111605: move kfreediskspace to kde4support
David Faure
faure at kde.org
Fri Jul 19 19:46:58 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111605/#review36180
-----------------------------------------------------------
kio/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111605/#comment26780>
It was installed under the install dir directly...
staging/kde4support/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111605/#comment26781>
... so don't install it under kio/
It needs to go into another section of the cmakelists, one which installs into INCLUDE_INSTALL_DIR directly.
Tip: compare install_manifest.txt before and after the change.
- David Faure
On July 19, 2013, 2:54 p.m., Wojciech Kapuscinski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111605/
> -----------------------------------------------------------
>
> (Updated July 19, 2013, 2:54 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> move kfreediskspace to kde4support
>
>
> Diffs
> -----
>
> kio/CMakeLists.txt 04b1495
> kio/kfile/kdiskfreespace.h fcaee8d
> kio/kfile/kdiskfreespace.cpp
> staging/kde4support/src/CMakeLists.txt 137ada2
>
> Diff: http://git.reviewboard.kde.org/r/111605/diff/
>
>
> Testing
> -------
>
> it builds
>
>
> Thanks,
>
> Wojciech Kapuscinski
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130719/7efe3fa9/attachment.html>
More information about the Kde-frameworks-devel
mailing list