Review Request 111609: Replace signals: with Q_SIGNALS: and slots with Q_SLOTS: everywhere in kdelibs

Wojciech Kapuscinski wojtask9.kde at gmail.com
Fri Jul 19 18:46:57 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111609/
-----------------------------------------------------------

Review request for KDE Frameworks.


Description
-------

Replace signals: with Q_SIGNALS: and slots with Q_SLOTS: everywhere in kdelibs


Diffs
-----

  CMakeLists.txt 34faf20 
  kdeui/dialogs/klinkdialog.h 1d98548 
  kdeui/sonnet/tests/test_dictionarycombobox.cpp 51e4059 
  kdeui/tests/krichtexteditor/krichtexteditor.h 19cde36 
  kdeui/util/kimagecache.cpp 2f619a7 
  kfile/kdiroperatordetailview_p.h a1ec72c 
  kfile/kurlnavigatortogglebutton_p.h 6760cd2 
  kfile/tests/kurlnavigatortest.h 4b19b61 
  khtml/ecma/debugger/callstackdock.h 0b11946 
  khtml/ecma/debugger/consoledock.h a62c968 
  khtml/ecma/debugger/debugdocument.h 1dc7970 
  khtml/html/html_objectimpl.h ba64c57 
  khtml/khtml_settings.cpp 5ed0aeb 
  khtml/khtmlviewbarwidget.h b620466 
  khtml/ui/findbar/khtmlfind_p.h a138e99 
  khtml/ui/findbar/khtmlfindbar.h e051ffb 
  khtml/ui/passwordbar/storepassbar.h 0e38f1c 
  kinit/klauncher.h cf5679d 
  kio/kfile/kabstractfilewidget.h dbbda61 
  kio/kfile/kcommentwidget_p.h 95488ea 
  kio/kio/delegateanimationhandler_p.h bd26006 
  kio/tests/fileundomanagertest.h ebd02fa 
  kjsembed/kjsembed/slotproxy.cpp 0c6c56c 
  knewstuff/knewstuff3/core/provider.h a92d42d 
  knewstuff/knewstuff3/ui/imagepreviewwidget.h f926084 
  knewstuff/knewstuff3/ui/itemsviewbasedelegate.h 543a749 
  knewstuff/tests/knewstuff2_cache.h 38e1b2f 
  knewstuff/tests/knewstuff2_download.h d186872 
  knewstuff/tests/knewstuff2_test.h 853b66e 
  knewstuff/tests/knewstuffauthortest.cpp 96cf83f 
  knewstuff/tests/knewstuffentrytest.cpp 6be8e0a 
  knewstuff/tests/testTranslatable.cpp debc328 
  kparts/tests/parts.h 5194c5d 
  kross/modules/form.h 081bfca 
  kunitconversion/tests/categorytest.h 3e74c1b 
  kunitconversion/tests/convertertest.h 99fe770 
  kunitconversion/tests/valuetest.h b2c5086 
  staging/itemviews/CMakeLists.txt 71169639 
  staging/itemviews/autotests/klistwidgetsearchlinetest.cpp 10bb491 
  staging/kde4attic/CMakeLists.txt 990cf8f 
  staging/kde4attic/src/kcupsoptionsjobwidget_p.h 9302f20 
  staging/kde4attic/src/kcupsoptionswidget_p.h fc5c9e1 
  staging/kde4attic/src/kdatetimeedit.cpp 17b8a7d 
  staging/kde4attic/src/ktcpsocket.h eb782d0 
  staging/kde4attic/tests/kanimatedbuttontest.h 3e98d70 
  staging/kde4support/CMakeLists.txt 7f8700f 
  staging/kde4support/autotests/kfadewidgeteffecttest.cpp a4ef0b8 
  staging/kde4support/src/kdeui/kapplication.h 62e98f9 
  staging/kguiaddons/tests/kmodifierkeyinfotest.cpp 981b153 
  staging/ktextwidgets/src/kregexpeditor/kregexpeditorinterface.h 4e8d73b 
  staging/kwidgets/CMakeLists.txt 32b4263 
  tier1/kwindowsystem/src/kwindowsystem_mac.cpp 4f7897e 
  tier1/solid/CMakeLists.txt 4940971 
  tier1/solid/autotests/fakehardwaretest.h 406f153 
  tier1/solid/autotests/halbasictest.h 82dd2c8 
  tier1/solid/autotests/solidhwtest.h 3b0b15e 
  tier1/solid/autotests/solidmttest.cpp 3298773 
  tier1/solid/src/solid/backends/win/winacadapter.h 15d334e 
  tier1/solid/src/solid/backends/win/winbattery.h 17ae47e 
  tier1/solid/src/solid/backends/win/windevicemanager.h b2d3c40 
  tier1/solid/src/solid/backends/win/wingenericinterface.h 16fa0ce 
  tier1/solid/src/solid/backends/win/winopticaldrive.h ce6c2c4 
  tier1/solid/src/solid/backends/win/winstorageaccess.h 10c92e8 
  tier2/kauth/src/kauthactionreply.h 9ed7860 

Diff: http://git.reviewboard.kde.org/r/111609/diff/


Testing
-------

it builds (the same way like jenkins)
all tests OK


Thanks,

Wojciech Kapuscinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130719/9c121073/attachment.html>


More information about the Kde-frameworks-devel mailing list