cannot compile after latest attica update

[Stefanie Dargel]

> On Sunday, July 14, 2013 07:37:07 PM Hugo Pereira Da Costa wrote:
> 
> 
> Hello I'm unable to compile neither plasma-workspace nor kde-workspace
> against  kf5 (and in fact against attica) after latest update of attica.
> Error is: /usr/bin/ld: cannot find -lLibAttica::attica It seems (but I
> might be wrong) that there are some issues related to  the addition of
> "NAMESPACE LibAttica::" in CMakeLists.txt (from attica) and
> set(LibAttica_LIBRARIES LibAttica::attica) in LibAtticaConfig.cmake.in Any
> clue ? Is there some changes to propagate to CMakeLists ? Thanks in
> advance, Hugo tbh: right now plasma-workspace has other issues but this is
> temporary I  assume and I don't really need it for the moment anyway
> 

Hi Hugo,

did you get it to build? For me the changes at the bottom to two CMakeLists fix some of the errors (disclaimer: I'm a very beginnery programmer with no experience in KDE developing, but I'm trying to learn).

Is it supposed to be "oxygenanimation.h" or "oxygenanimationS.h"? The filename has an "s" at the end, but several files try to include "oxygenanimation.h".

I'm also getting a lot of errors regarding undefined references in kde-workspace/libs/oxygen/oxygenhelper.cpp (mostly to KColorScheme::, KStatefulBrush:: and KColorUtils:: stuff)

Thanks for your work, I'm looking forward to try Oxygen-theme wit Qt5.

Stefanie

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4c48293..c7408c5 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -26,7 +26,6 @@ find_package(Qt5Transitional MODULE)
 find_package(Qt5Quick REQUIRED NO_MODULE)
 find_package(Qt5X11Extras REQUIRED NO_MODULE)
 
-find_package(kde4support REQUIRED NO_MODULE) // has to be after find_package(KDELibs4 REQUIRED NO_MODULE)
 
 #include(ConfigureChecks.cmake)
 
@@ -35,19 +34,24 @@ add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0)
 find_package(kdeqt5staging REQUIRED NO_MODULE)
 # Load CMake, Compiler and InstallDirs settings from KF5 and the following are already somewhat "done" tier1/tier2 libs from kdelibs:
 find_package(KF5 MODULE REQUIRED COMPONENTS CMake Compiler InstallDirs
-                                            XmlGui KIdleTime ItemModels KWidgetsAddons KWindowSystem KCodecs KArchive KCoreAddons Solid ThreadWeaver
-                                           KConfig KAuth kjs KWallet KIconThemes KDBusAddons Sonnet
-                                            ki18n kguiaddons kservice kwidgets ItemViews KNotifications KCompletion KJobWidgets KConfigWidgets KIconThemes)
+                                             KIdleTime ItemModels KWidgetsAddons KWindowSystem KCodecs KArchive KCoreAddons Solid ThreadWeaver
+                                           KConfig KAuth kjs KWallet KDBusAddons Sonnet 
+                                            KI18n KGuiAddons KService KWidgets ItemViews KNotifications  KJobWidgets KConfigWidgets KIconThemes KCompletion ktextwidgets XmlGui)
 
-find_package(ki18n REQUIRED NO_MODULE)
+find_package(KCrash REQUIRED NO_MODULE)
 find_package(kio REQUIRED NO_MODULE)
-find_package(ktextwidgets REQUIRED NO_MODULE)
 find_package(Plasma REQUIRED NO_MODULE)
-find_package(kdeclarative REQUIRED NO_MODULE)
+#find_package(kdeclarative REQUIRED NO_MODULE) // is called later
 
 # needed for set_package_properties macro
 find_package(KDELibs4 REQUIRED NO_MODULE)
+find_package(KDE4Support REQUIRED NO_MODULE) // has to be after find_package(KDELibs4 REQUIRED NO_MODULE)
 
+find_package(LibAttica NO_MODULE) // maybe only temporary as in plasma-frameworks?
+set_package_properties(LibAttica PROPERTIES DESCRIPTION "Support for Get Hot New Stuff related stuff"
+                       URL "https://projects.kde.org/attica"
+                       TYPE REQUIRED
+                      )
 
 option(WITH_XINERAMA "Xinerama support for multi-headed X displays" ON)

diff --git a/plasma/generic/wallpapers/image/CMakeLists.txt b/plasma/generic/wallpapers/image/CMakeLists.txt
index 27e20a3..3536c3c 100644
--- a/plasma/generic/wallpapers/image/CMakeLists.txt
+++ b/plasma/generic/wallpapers/image/CMakeLists.txt
@@ -19,7 +19,7 @@ target_link_libraries(plasma_wallpaper_imageplugin
          ${KDE4_KFILE_LIBS}
          ${KDE4_KNEWSTUFF3_LIBS}
          ${KDE4_THREADWEAVER_LIBRARY}
-         KDE4__kde4support)
+         ${KDE4Support_LIBRARIES}) // As mentioned by Alexander Neundorf in a previous email
 
 install(TARGETS plasma_wallpaper_imageplugin DESTINATION ${QML_INSTALL_DIR}/org/kde/plasma/wallpapers/image)