Review Request 111456: Create KCrash framework

[Stefanie Dargel]

Hi,

unfortunally KCrash causes kdelibs-frameworks to fail for me when build from scratch with kdesrc-build due to a cmake error:

CMake Error at KDE/KF5/inst/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:108 (message):
  Could NOT find KF5 (missing: KCoreAddons KWindowSystem) (found suitable version "5.0.0", minimum required is "5.0.0")
Call Stack (most recent call first):
  KDE/KF5/inst/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:315 (_FPHSA_FAILURE_MESSAGE)
  KDE/KF5/inst/share/ECM/find-modules/FindKF5.cmake:216 (find_package_handle_standard_args)
  staging/kcrash/src/CMakeLists.txt:3 (find_package)

commenting out that line ( find_package(KF5 5.0.0 REQUIRED MODULE COMPONENTS CMake Compiler InstallDirs KCoreAddons KWindowSystem) ) in staging/kcrash/src/CMakeLists.txt fixes the issue for me. Is it trying to find KCoreAddons and KWindowSystem before they are beeing build/configured?

Thanks for your work!

Stefanie Dargel

Am Freitag, 12. Juli 2013, 08:07:43 schrieb Benjamin Port:



This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111456/[1] 


This change has been marked as submitted. 


Review request for KDE Frameworks.
By Benjamin Port. 
Updated July 12, 2013, 8:07 a.m. 
Description 
Create KCrash framework

Copy/Paste struct from klauncher_cmds to kcrash and rename it to avoid conflict 

Diffs 
     *  kded/CMakeLists.txt (6283135) 
     *  kdeui/CMakeLists.txt (35b4019) 
     *  kdeui/util/config-strlcpy.h.cmake () 
     *  kdeui/util/kcrash.h (f0c92f8) 
     *  kdeui/util/kcrash.cpp (2e36c03) 
     *  kdeui/util/strlcpy-fake.c (e75cae3) 
     *  kinit/CMakeLists.txt (52c132c) 
     *  kinit/kinit.cpp (d95f3a4) 
     *  kio/CMakeLists.txt (812bbaa) 
     *  staging/CMakeLists.txt (3832396) 
     *  staging/kcrash/CMakeLists.txt (PRE-CREATION) 
     *  staging/kcrash/KCrashConfig.cmake.in (PRE-CREATION) 
     *  staging/kcrash/src/CMakeLists.txt (PRE-CREATION) 
     *  staging/kcrash/src/config-kcrash.h.cmake (PRE-CREATION) 
     *  staging/kde4support/autotests/CMakeLists.txt (d179a1c) 
     *  staging/kde4support/src/CMakeLists.txt (8b2cd5b) 
View Diff[2] 




--------
[1] http://git.reviewboard.kde.org/r/111456/
[2] http://git.reviewboard.kde.org/r/111456/diff/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130713/657ac485/attachment.html>