Review Request 111491: Rename kde4support framework to KDE4Support

Alexander Neundorf neundorf at kde.org
Fri Jul 12 19:57:49 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111491/#review35901
-----------------------------------------------------------



cmake/modules/FindKDE4Internal.cmake
<http://git.reviewboard.kde.org/r/111491/#comment26579>

    I think this line can be removed completely.
    I think ${KDE4_KDE4SUPPORT_LIBRARY} is not used anywhere withint kdelibs.


- Alexander Neundorf


On July 12, 2013, 12:49 p.m., Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111491/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 12:49 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> In order to have all frameworks using the same name policy (i.e. use CamelCase for libraries names) rename kde4support framework lib to KDE4Support
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a03f33b 
>   cmake/modules/FindKDE4Internal.cmake 8786a9d 
>   interfaces/kimproxy/library/CMakeLists.txt 5bc4b4d 
>   kdeui/tests/CMakeLists.txt b6d5b30 
>   kdewidgets/CMakeLists.txt 1f72c6f 
>   khtml/java/CMakeLists.txt bb6ab56 
>   khtml/java/tests/CMakeLists.txt 55b38da 
>   kinit/CMakeLists.txt 656d2a7 
>   kio/CMakeLists.txt c5cc280 
>   kjsembed/kjscmd/CMakeLists.txt 9ec86dc 
>   staging/kde4attic/src/CMakeLists.txt 31e36e5 
>   staging/kde4support/CMakeLists.txt b01602e 
>   staging/kde4support/autotests/CMakeLists.txt 0e674ac 
>   staging/kde4support/src/CMakeLists.txt 96ba1ad 
>   staging/kde4support/tests/CMakeLists.txt 4e228c3 
>   staging/kwidgets/tests/CMakeLists.txt a847d08 
> 
> Diff: http://git.reviewboard.kde.org/r/111491/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Port
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130712/fc5d4700/attachment.html>


More information about the Kde-frameworks-devel mailing list