Review Request 111453: move kacceleratormanager to KWidgetAddons

David Faure faure at kde.org
Thu Jul 11 14:46:27 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111453/#review35859
-----------------------------------------------------------

Ship it!



kdeui/shortcuts/kacceleratormanager.cpp
<http://git.reviewboard.kde.org/r/111453/#comment26555>

    move the { on its own line :)



kdeui/shortcuts/kacceleratormanager_private.h
<http://git.reviewboard.kde.org/r/111453/#comment26556>

    call -> calls


- David Faure


On July 11, 2013, 2:42 p.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111453/
> -----------------------------------------------------------
> 
> (Updated July 11, 2013, 2:42 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> move kacceleratormanager to KWidgetAddons.
> 
> 
> Changes:
> rename kacceleratormanager_private.h -> kacceleratormanager_p.h
> move KAcceleratorManagerPrivate class definition from kacceleratormanager.cpp to kacceleratormanager_p.h
> set standard action names when KStandardAction is constructed for the firs time.
> 
> 
> Diffs
> -----
> 
>   kdeui/shortcuts/kacceleratormanager_private.h ab04d42 
>   kdeui/shortcuts/kacceleratormanager.cpp 990b093 
>   kdeui/shortcuts/kacceleratormanager.h 68e87d2 
>   kdeui/CMakeLists.txt 35b4019 
>   staging/kwidgets/src/actions/kstandardaction.cpp 0c3733a 
>   tier1/kwidgetsaddons/src/CMakeLists.txt 82d42db 
> 
> Diff: http://git.reviewboard.kde.org/r/111453/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130711/b823e7c2/attachment.html>


More information about the Kde-frameworks-devel mailing list