Review Request 111210: Move the XMLGUI technology to xmlgui/

Wed Jul 10 11:02:27 UTC 2013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111210/#review35830
-----------------------------------------------------------

Woa! This patch is turning into the Godzilla of the KF5 patches. It took me *forever* to review it.
Will you be at Akademy? You deserve some drinks. :-)

Anyway found some issues, most notably:
 * Use #include <> in public headers;
 * When you get the choice use QStringLiteral;
 * Use qPrintable() only with qDebug and friends, otherwise you might not get the encoding you expect.

kdeui/actions/kactioncategory.h
<http://git.reviewboard.kde.org/r/111210/#comment26274>

    Should be a <> include

kdeui/actions/kactioncategory.h
<http://git.reviewboard.kde.org/r/111210/#comment26275>

    Why the extra empty line?

kdeui/actions/kactioncategory.h
<http://git.reviewboard.kde.org/r/111210/#comment26276>

    Should be <> include.

kdeui/actions/kactioncollection.h
<http://git.reviewboard.kde.org/r/111210/#comment26277>

    Should be <> include.

kdeui/actions/kactioncollection.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26278>

    QStringLiteral would be a better fit I think

kdeui/actions/kactioncollection.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26279>

    ditto.

kdeui/actions/kactioncollection.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26280>

    ditto.

kdeui/actions/ktoggletoolbaraction.h
<http://git.reviewboard.kde.org/r/111210/#comment26281>

    Should be a <> include.

kdeui/dialogs/kaboutapplicationdialog.h
<http://git.reviewboard.kde.org/r/111210/#comment26282>

    Should be a <> include.

kdeui/dialogs/kaboutapplicationdialog.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26283>

    QStringLiteral should fit better I think.

kdeui/dialogs/kaboutapplicationdialog.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26284>

    ditto.

kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26285>

    ditto.

kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26286>

    ditto.

kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26287>

    ditto.

kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26288>

    ditto.

kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26289>

    Why dropping the const here?

kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26290>

    QStringLiteral

kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26291>

    constBegin() + constEnd() since you use a const_iterator type (otherwise probably won't build with the QT_STRICT_ITERATORS toggle).

kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26292>

    QStringLiteral

kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26293>

    QStringLiteral

kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26294>

    QStringLiteral

kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26295>

    Add spaces around <<

kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26296>

    ditto.

kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26297>

    No need for a new line here.

kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26298>

    Maybe put that on a single line to make it easier to turn on/off.

kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26299>

    QStringLiteral

kdeui/dialogs/kaboutkdedialog_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26300>

    QStringLiteral

kdeui/dialogs/kaboutkdedialog_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26301>

    QStringLiteral

kdeui/dialogs/kaboutkdedialog_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26302>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26303>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26304>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26305>

    should be QComboBox(this)

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26306>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26307>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26308>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26309>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26310>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26311>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26312>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26313>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26314>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26315>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26316>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26317>

    QStringLiteral

kdeui/dialogs/kbugreport.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26318>

    QStringLiteral

kdeui/dialogs/kedittoolbar.h
<http://git.reviewboard.kde.org/r/111210/#comment26319>

    Should be <> include.

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26320>

    Use #if 0 #endif instead of a comment here, to make it easier to turn on/off.

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26321>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26322>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26324>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26325>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26326>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26327>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26328>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26329>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26330>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26331>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26332>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26333>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26334>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26335>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26336>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26337>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26338>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26339>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26340>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26341>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26342>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26343>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26344>

    QStringLiteral

kdeui/dialogs/kedittoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26345>

    QStringLiteral

kdeui/dialogs/kedittoolbar_p.h
<http://git.reviewboard.kde.org/r/111210/#comment26346>

    QStringLiteral

kdeui/dialogs/kshortcutschemeseditor.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26347>

    QStringLiteral

kdeui/dialogs/kshortcutschemeseditor.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26348>

    QStringLiteral

kdeui/dialogs/kshortcutschemeseditor.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26349>

    QStringLiteral

kdeui/dialogs/kshortcutschemeseditor.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26350>

    QStringLiteral

kdeui/dialogs/kshortcutsdialog.h
<http://git.reviewboard.kde.org/r/111210/#comment26351>

    Should be a <> include.

kdeui/dialogs/kshortcutsdialog.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26352>

    Keep using a class only include here.

kdeui/dialogs/kshortcutsdialog.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26353>

    QStringLiteral

kdeui/dialogs/kshortcutsdialog.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26354>

    QStringLiteral

kdeui/dialogs/kshortcutsdialog.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26355>

    QStringLiteral

kdeui/dialogs/kshortcutseditor.h
<http://git.reviewboard.kde.org/r/111210/#comment26356>

    Should be a <> include.

kdeui/dialogs/kshortcutseditor.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26357>

    Please stick to class only include here.

kdeui/dialogs/kshortcutseditor.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26358>

    QStringLiteral

kdeui/dialogs/kshortcutseditor.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26359>

    QStringLiteral

kdeui/dialogs/kshortcutseditordelegate.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26360>

    QStringLiteral

kdeui/dialogs/kshortcutseditordelegate.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26361>

    QStringLiteral

kdeui/dialogs/kswitchlanguagedialog_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26363>

    QStringLiteral

kdeui/dialogs/kswitchlanguagedialog_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26364>

    QStringLiteral

kdeui/dialogs/kswitchlanguagedialog_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26365>

    QStringLiteral

kdeui/dialogs/kswitchlanguagedialog_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26366>

    QStringLiteral

kdeui/dialogs/kswitchlanguagedialog_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26367>

    QStringLiteral

kdeui/dialogs/kswitchlanguagedialog_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26368>

    QStringLiteral

kdeui/dialogs/kswitchlanguagedialog_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26369>

    QStringLiteral

kdeui/shortcuts/kshortcutschemeshelper.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26370>

    QStringLiteral

kdeui/shortcuts/kshortcutschemeshelper.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26371>

    QStringLiteral

kdeui/shortcuts/kshortcutschemeshelper.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26372>

    QStringLiteral

kdeui/shortcuts/kshortcutschemeshelper.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26373>

    QStringLiteral

kdeui/shortcuts/kshortcutschemeshelper.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26374>

    QStringLiteral

kdeui/shortcuts/kshortcutschemeshelper.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26375>

    QStringLiteral

kdeui/shortcuts/kshortcutschemeshelper.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26376>

    QStringLiteral

kdeui/shortcuts/kshortcutschemeshelper.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26377>

    QStringLiteral

kdeui/shortcuts/kshortcutschemeshelper.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26378>

    QStringLiteral

kdeui/tests/kbugreporttest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26379>

    QStringLiteral

kdeui/tests/kbugreporttest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26380>

    QStringLiteral

kdeui/tests/kbugreporttest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26381>

    QStringLiteral

kdeui/tests/kbugreporttest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26382>

    QStringLiteral

kdeui/tests/kbugreporttest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26383>

    QStringLiteral

kdeui/tests/kmainwindowrestoretest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26384>

    QStringLiteral

kdeui/tests/kmainwindowrestoretest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26385>

    QStringLiteral

kdeui/tests/kmainwindowtest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26386>

    QStringLiteral

kdeui/tests/kmainwindowtest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26387>

    QStringLiteral

kdeui/tests/kmainwindowtest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26388>

    QStringLiteral

kdeui/tests/kmainwindowtest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26389>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26390>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26391>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26392>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26393>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26394>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26395>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26396>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26397>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26398>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26399>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26400>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26401>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26402>

    QStringLiteral

kdeui/tests/ktoolbar_unittest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26403>

    QStringLiteral

kdeui/tests/ktoolbartest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26404>

    QStringLiteral

kdeui/tests/ktoolbartest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26405>

    QStringLiteral

kdeui/tests/kxmlguiwindowtest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26406>

    QStringLiteral

kdeui/tests/kxmlguiwindowtest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26407>

    QStringLiteral

kdeui/tests/kxmlguiwindowtest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26408>

    QStringLiteral

kdeui/tests/testguiclient.h
<http://git.reviewboard.kde.org/r/111210/#comment26409>

    QStringLiteral

kdeui/tests/testguiclient.h
<http://git.reviewboard.kde.org/r/111210/#comment26410>

    QStringLiteral

kdeui/tests/testxmlguiwindow.h
<http://git.reviewboard.kde.org/r/111210/#comment26411>

    QStringLiteral

kdeui/tests/testxmlguiwindow.h
<http://git.reviewboard.kde.org/r/111210/#comment26412>

    QStringLiteral

kdeui/tests/testxmlguiwindow.h
<http://git.reviewboard.kde.org/r/111210/#comment26413>

    QStringLiteral

kdeui/widgets/khelpmenu.h
<http://git.reviewboard.kde.org/r/111210/#comment26414>

    Should be a <> include.

kdeui/widgets/khelpmenu.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26415>

    QStringLiteral

kdeui/widgets/khelpmenu.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26416>

    QStringLiteral

kdeui/widgets/khelpmenu.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26417>

    QStringLiteral

kdeui/widgets/khelpmenu.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26418>

    QStringLiteral

kdeui/widgets/khelpmenu.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26419>

    QStringLiteral

kdeui/widgets/khelpmenu.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26420>

    QStringLiteral

kdeui/widgets/khelpmenu.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26421>

    QStringLiteral

kdeui/widgets/khelpmenu.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26422>

    QStringLiteral

kdeui/widgets/khelpmenu.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26423>

    QStringLiteral

kdeui/widgets/kkeysequencewidget.h
<http://git.reviewboard.kde.org/r/111210/#comment26424>

    Should be a <> include.

kdeui/widgets/kkeysequencewidget.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26425>

    QStringLiteral

kdeui/widgets/kkeysequencewidget.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26426>

    QStringLiteral

kdeui/widgets/kkeysequencewidget.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26427>

    QStringLiteral

kdeui/widgets/kkeysequencewidget.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26428>

    QStringLiteral

kdeui/widgets/kshortcutwidget.h
<http://git.reviewboard.kde.org/r/111210/#comment26429>

    Should be <> include.

kdeui/xmlgui/kmainwindow.h
<http://git.reviewboard.kde.org/r/111210/#comment26430>

    Should be <> include.

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26431>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26432>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26433>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26434>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26435>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26436>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26437>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26438>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26439>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26440>

    Please remove the space after (

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26441>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26442>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26443>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26444>

    QStringLiteral

kdeui/xmlgui/kmainwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26445>

    QStringLiteral

kdeui/xmlgui/kmainwindowiface.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26446>

    QStringLiteral

kdeui/xmlgui/kmenumenuhandler_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26447>

    Use class only includes.

kdeui/xmlgui/kmenumenuhandler_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26448>

    QStringLiteral

kdeui/xmlgui/ktoolbar.h
<http://git.reviewboard.kde.org/r/111210/#comment26449>

    Should be a <> include.

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26450>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26451>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26452>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26453>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26454>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26455>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26456>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26457>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26458>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26459>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26460>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26461>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26462>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26464>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26465>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26466>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26467>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26468>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26469>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26470>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26471>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26472>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26473>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26474>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26475>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26476>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26477>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26478>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26479>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26480>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26481>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26482>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26483>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26484>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26485>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26486>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26487>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26488>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26489>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26490>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26491>

    QStringLiteral

kdeui/xmlgui/ktoolbar.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26492>

    QStringLiteral

kdeui/xmlgui/ktoolbarhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26493>

    QStringLiteral

kdeui/xmlgui/ktoolbarhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26495>

    QStringLiteral

kdeui/xmlgui/ktoolbarhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26496>

    QStringLiteral

kdeui/xmlgui/kxmlguibuilder.h
<http://git.reviewboard.kde.org/r/111210/#comment26497>

    Should be <> include.

kdeui/xmlgui/kxmlguibuilder.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26499>

    QStringLiteral

kdeui/xmlgui/kxmlguibuilder.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26501>

    Why not .toUtf8() (or .toUtf8().constData()) here?

kdeui/xmlgui/kxmlguibuilder.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26502>

    ditto.

kdeui/xmlgui/kxmlguibuilder.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26503>

    ditto.

kdeui/xmlgui/kxmlguiclient.h
<http://git.reviewboard.kde.org/r/111210/#comment26504>

    Should be <> include.

kdeui/xmlgui/kxmlguiclient.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26505>

    Keep using class only includes.

kdeui/xmlgui/kxmlguiclient.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26506>

    QStringLiteral

kdeui/xmlgui/kxmlguiclient.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26507>

    QStringLiteral

kdeui/xmlgui/kxmlguiclient.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26508>

    QStringLiteral

kdeui/xmlgui/kxmlguiclient.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26511>

    .toUtf8() (or .toUtf8().constData()) instead of qPrintable

kdeui/xmlgui/kxmlguiclient.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26512>

    QStringLiteral

kdeui/xmlgui/kxmlguiclient.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26513>

    QStringLiteral

kdeui/xmlgui/kxmlguiclient.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26515>

    .toUf8()

kdeui/xmlgui/kxmlguiclient.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26516>

    .toUtf8()

kdeui/xmlgui/kxmlguifactory.h
<http://git.reviewboard.kde.org/r/111210/#comment26517>

    Should be <> include.

kdeui/xmlgui/kxmlguifactory.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26518>

    QStringLiteral

kdeui/xmlgui/kxmlguifactory.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26519>

    QStringLiteral

kdeui/xmlgui/kxmlguifactory.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26520>

    QStringLiteral

kdeui/xmlgui/kxmlguifactory.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26521>

    QStringLiteral

kdeui/xmlgui/kxmlguifactory.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26522>

    QStringLiteral

kdeui/xmlgui/kxmlguifactory_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26523>

    QStringLiteral

kdeui/xmlgui/kxmlguifactory_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26524>

    QStringLiteral

kdeui/xmlgui/kxmlguifactory_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26525>

    QStringLiteral

kdeui/xmlgui/kxmlguifactory_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26526>

    QStringLiteral

kdeui/xmlgui/kxmlguifactory_p.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26527>

    QStringLiteral

kdeui/xmlgui/kxmlguiversionhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26528>

    Stick to class only includes.

kdeui/xmlgui/kxmlguiversionhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26529>

    QStringLiteral

kdeui/xmlgui/kxmlguiversionhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26530>

    QStringLiteral

kdeui/xmlgui/kxmlguiversionhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26531>

    QStringLiteral

kdeui/xmlgui/kxmlguiversionhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26532>

    QStringLiteral

kdeui/xmlgui/kxmlguiversionhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26533>

    QStringLiteral

kdeui/xmlgui/kxmlguiversionhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26534>

    QStringLiteral

kdeui/xmlgui/kxmlguiversionhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26535>

    QStringLiteral

kdeui/xmlgui/kxmlguiversionhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26536>

    QStringLiteral

kdeui/xmlgui/kxmlguiversionhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26537>

    QStringLiteral

kdeui/xmlgui/kxmlguiversionhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26538>

    QStringLiteral

kdeui/xmlgui/kxmlguiversionhandler.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26539>

    QStringLiteral

kdeui/xmlgui/kxmlguiwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26540>

    QStringLiteral

kdeui/xmlgui/kxmlguiwindow.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26541>

    QStringLiteral

staging/xmlgui/tests/kxmlguitest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26542>

    QStringLiteral

staging/xmlgui/tests/kxmlguitest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26543>

    QStringLiteral

staging/xmlgui/tests/kxmlguitest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26544>

    QStringLiteral

staging/xmlgui/tests/kxmlguitest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26545>

    QStringLiteral

staging/xmlgui/tests/kxmlguitest.cpp
<http://git.reviewboard.kde.org/r/111210/#comment26546>

    QStringLiteral

- Kevin Ottens

On July 10, 2013, 9:48 a.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111210/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 9:48 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Move:
> * KAboutApplicationDialog
> * KBugReport
> * KHelpMenu
> * KShortcutsEditor
> * KShortcutsDialog
> * KEditToolBar
> * KShortcutWidget
> * KKeySequenceWidget
> * KXmlGuiClient
> * KXmlGuiFactory
> * KXmlGuiBuilder
> * KMainWindow
> * KToolBar
> * KActionCollection
> * KToggleBarAction
> * KActionCategory
> to XmlGui.
> 
> This also move the FindLibAttica module in xmlgui/.
> 
> Notes:
>  * the code that uses KGestureMap has been commented. What to do?
>  * the code that uses KGlobalSettings has been commented. Waiting for a decision to be taken in the thread http://lists.kde.org/?l=kde-frameworks-devel&m=137149104802300&w=2
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d7c5260 
>   cmake/modules/CMakeLists.txt 4602cd7 
>   cmake/modules/FindLibAttica.cmake e758a5a 
>   kdeui/CMakeLists.txt 35b4019 
>   kdeui/TODO.xmlgui  
>   kdeui/actions/kactioncategory.h 25f3be8 
>   kdeui/actions/kactioncategory.cpp  
>   kdeui/actions/kactioncollection.h aa6603a 
>   kdeui/actions/kactioncollection.cpp fc4e067 
>   kdeui/actions/ktoggletoolbaraction.h e937ba3 
>   kdeui/actions/ktoggletoolbaraction.cpp 5db4192 
>   kdeui/dialogs/kaboutapplicationconfigattica_p.h.cmake  
>   kdeui/dialogs/kaboutapplicationdialog.h 7459f7e 
>   kdeui/dialogs/kaboutapplicationdialog.cpp d656fa2 
>   kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.h  
>   kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp 8933202 
>   kdeui/dialogs/kaboutapplicationpersonlistview_p.h  
>   kdeui/dialogs/kaboutapplicationpersonlistview_p.cpp  
>   kdeui/dialogs/kaboutapplicationpersonmodel_p.h 5001da8 
>   kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp 25d2765 
>   kdeui/dialogs/kaboutkdedialog_p.h  
>   kdeui/dialogs/kaboutkdedialog_p.cpp 35061f6 
>   kdeui/dialogs/kbugreport.h c3ace5e 
>   kdeui/dialogs/kbugreport.cpp cf56aa3 
>   kdeui/dialogs/kedittoolbar.h 217c3c6 
>   kdeui/dialogs/kedittoolbar.cpp b4fb8cb 
>   kdeui/dialogs/kedittoolbar_p.h c6436d2 
>   kdeui/dialogs/kshortcuteditwidget.cpp 228a401 
>   kdeui/dialogs/kshortcutschemeseditor.cpp 095aeeb 
>   kdeui/dialogs/kshortcutsdialog.h 54082f9 
>   kdeui/dialogs/kshortcutsdialog.cpp 1a187b3 
>   kdeui/dialogs/kshortcutsdialog.ui  
>   kdeui/dialogs/kshortcutsdialog_p.h 78067fa 
>   kdeui/dialogs/kshortcutseditor.h 5b7e24a 
>   kdeui/dialogs/kshortcutseditor.cpp 5fad58b 
>   kdeui/dialogs/kshortcutseditordelegate.cpp 53c619c 
>   kdeui/dialogs/kshortcutseditoritem.cpp 3be65ef 
>   kdeui/dialogs/kswitchlanguagedialog_p.h  
>   kdeui/dialogs/kswitchlanguagedialog_p.cpp 466d8dc 
>   kdeui/kdepackages.h  
>   kdeui/make_kdepackages_updated.py  
>   kdeui/shortcuts/kshortcutschemeshelper.cpp 1ea1631 
>   kdeui/shortcuts/kshortcutschemeshelper_p.h  
>   kdeui/tests/CMakeLists.txt b6d5b30 
>   kdeui/tests/kactioncategorytest.h  
>   kdeui/tests/kactioncategorytest.cpp  
>   kdeui/tests/kbugreporttest.cpp cd71173 
>   kdeui/tests/kmainwindow_unittest.h  
>   kdeui/tests/kmainwindow_unittest.cpp  
>   kdeui/tests/kmainwindowrestoretest.h  
>   kdeui/tests/kmainwindowrestoretest.cpp 95146a2 
>   kdeui/tests/kmainwindowtest.h  
>   kdeui/tests/kmainwindowtest.cpp 3deac97 
>   kdeui/tests/ktoolbar_unittest.cpp 4e1431b 
>   kdeui/tests/ktoolbartest.cpp 25c0598 
>   kdeui/tests/kwindowtest.h 24c344a 
>   kdeui/tests/kwindowtest.cpp 4217f65 
>   kdeui/tests/kwindowtest.rc  
>   kdeui/tests/kxmlgui_unittest.h  
>   kdeui/tests/kxmlgui_unittest.cpp cf99a0a 
>   kdeui/tests/kxmlguitest.h  
>   kdeui/tests/kxmlguitest.cpp cc8d9d3 
>   kdeui/tests/kxmlguitest_part.rc  
>   kdeui/tests/kxmlguitest_shell.rc  
>   kdeui/tests/kxmlguiwindowtest.cpp ac484e2 
>   kdeui/tests/kxmlguiwindowtestui.rc  
>   kdeui/tests/testguiclient.h f10207e 
>   kdeui/tests/testxmlguiwindow.h 0ac78fe 
>   kdeui/widgets/khelpmenu.h 9210810 
>   kdeui/widgets/khelpmenu.cpp 24e44db 
>   kdeui/widgets/kkeysequencewidget.h 6ea1b5a 
>   kdeui/widgets/kkeysequencewidget.cpp 235353f 
>   kdeui/widgets/kkeysequencewidget_p.h  
>   kdeui/widgets/kshortcutwidget.h 18ec960 
>   kdeui/widgets/kshortcutwidget.cpp  
>   kdeui/widgets/kshortcutwidget.ui  
>   kdeui/xmlgui/kmainwindow.h 32e37cf 
>   kdeui/xmlgui/kmainwindow.cpp e7f2d31 
>   kdeui/xmlgui/kmainwindow_p.h 92646f3 
>   kdeui/xmlgui/kmainwindowiface.cpp 6c77d93 
>   kdeui/xmlgui/kmainwindowiface_p.h b59b2b1 
>   kdeui/xmlgui/kmenumenuhandler_p.h  
>   kdeui/xmlgui/kmenumenuhandler_p.cpp 27cd5c3 
>   kdeui/xmlgui/kpartgui.dtd  
>   kdeui/xmlgui/ktoolbar.h 94f5c81 
>   kdeui/xmlgui/ktoolbar.cpp 8157bb4 
>   kdeui/xmlgui/ktoolbarhandler.cpp 1ad8da6 
>   kdeui/xmlgui/ktoolbarhandler_p.h  
>   kdeui/xmlgui/kxmlgui.xsd  
>   kdeui/xmlgui/kxmlguibuilder.h e841384 
>   kdeui/xmlgui/kxmlguibuilder.cpp 04d760c 
>   kdeui/xmlgui/kxmlguiclient.h 3b06b50 
>   kdeui/xmlgui/kxmlguiclient.cpp 96ea35b 
>   kdeui/xmlgui/kxmlguifactory.h c6e853b 
>   kdeui/xmlgui/kxmlguifactory.cpp 272b010 
>   kdeui/xmlgui/kxmlguifactory_p.h  
>   kdeui/xmlgui/kxmlguifactory_p.cpp 42b97d4 
>   kdeui/xmlgui/kxmlguiversionhandler.cpp 3e6227b 
>   kdeui/xmlgui/kxmlguiversionhandler_p.h  
>   kdeui/xmlgui/kxmlguiwindow.h 218cd77 
>   kdeui/xmlgui/kxmlguiwindow.cpp a74eece 
>   kdeui/xmlgui/ui_standards.rc  
>   staging/xmlgui/CMakeLists.txt 6320a19 
>   staging/xmlgui/autotests/CMakeLists.txt 83c2b11 
>   staging/xmlgui/cmake/FindLibAttica.cmake PRE-CREATION 
>   staging/xmlgui/src/CMakeLists.txt 7eb71f4 
>   staging/xmlgui/src/config-xmlgui.h.cmake 58949d8 
>   staging/xmlgui/tests/CMakeLists.txt dce637f 
>   staging/xmlgui/tests/kxmlguitest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111210/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> * autotests/ktoolbar_unittest, 1 failed, core dumped
> * autotests/kxmlgui_unittest, 35 failed, core dumped
> * tests/kwindowtest segfaults
> * tests/kxmlguiwindowtest segfaults
> * autotests/kglobalshortcuttest, 5 failed
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130710/2716cf26/attachment-0001.html>