Review Request 110988: Port kio-file to QFile
Martin Klapetek
martin.klapetek at gmail.com
Tue Jul 9 21:50:23 UTC 2013
> On July 9, 2013, 9:39 p.m., David Faure wrote:
> > kioslave/file/file.cpp, line 476
> > <http://git.reviewboard.kde.org/r/110988/diff/5/?file=169752#file169752line476>
> >
> > coding style: no spaces inside parenthesis (same in a few other places).
Fwiw, the coding style in this file is mostly random. I'd reformat it all to proper coding style in another commit if you're ok with that.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110988/#review35814
-----------------------------------------------------------
On July 9, 2013, 9:26 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110988/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 9:26 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Ports away kioslave/file from unix/kde specific calls to QFile calls
>
>
> Diffs
> -----
>
> kioslave/file/file.h 93aeef4
> kioslave/file/file.cpp 6b8b268
> kioslave/file/file_unix.cpp 8b92e06
>
> Diff: http://git.reviewboard.kde.org/r/110988/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130709/ce33154a/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list