Review Request 110988: Port kio-file to QFile

Martin Klapetek martin.klapetek at gmail.com
Tue Jul 9 21:19:36 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110988/
-----------------------------------------------------------

(Updated July 9, 2013, 9:19 p.m.)


Review request for KDE Frameworks.


Changes
-------

All tests pass \o/

I've removed the rename() and del() parts from file_unix.cpp, these were causing various errors. Should I actually work on that as it's "_unix" and uses unix calls?


Description
-------

Ports away kioslave/file from unix/kde specific calls to QFile calls


Diffs (updated)
-----

  kioslave/file/file.h 93aeef4 
  kioslave/file/file.cpp 6b8b268 
  kioslave/file/file_unix.cpp 8b92e06 

Diff: http://git.reviewboard.kde.org/r/110988/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130709/307bcf9e/attachment.html>


More information about the Kde-frameworks-devel mailing list