Review Request 111422: Add addActions(QList<QAction *>) to KActionCollection

Commit Hook null at kde.org
Tue Jul 9 10:16:31 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111422/
-----------------------------------------------------------

(Updated July 9, 2013, 10:16 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Description
-------

In review https://git.reviewboard.kde.org/r/111424/ KRichTextWidget::createActions(KActionCollection *actionCollection) has been changed to QList<QAction *> KRichTextWidget::createActions() to remove the dependency on KActionCollection.

Effect of this change is that people have to add each action to the collection now. This method simplify things by allowing to add them all with a single call.


Diffs
-----

  kdeui/actions/kactioncollection.h 8ca6845 
  kdeui/actions/kactioncollection.cpp 7dc2987 

Diff: http://git.reviewboard.kde.org/r/111422/diff/


Testing
-------


Thanks,

Andrea Scarpino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130709/931bee18/attachment.html>


More information about the Kde-frameworks-devel mailing list