Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111409/
-----------------------------------------------------------

(Updated July 8, 2013, 4:09 p.m.)


Review request for KDE Frameworks.


Changes
-------

Some changes according to Kevin's review.


Description
-------

Finally my patch in Qt seems that will get to the dev branch soon, so let's start using it.

- Move the code from KGlobalSettings to the KDE platform theme to handle fonts properly.
- Port uses of KGlobalSettings::*Fonts to newer alternatives.
- Drop some MacOS switches regarding the fonts. It doesn't make sense since on MacOS we'll be running the MacOS QPA.


NOTE: KGlobalSettings::menuFont, toolBarFont and taskBarFont have some weird workaround that I'm unsure how to fix. Maybe I should instantiate one of them?


Diffs (updated)
-----

  kdeui/CMakeLists.txt 35b4019 
  kdeui/dialogs/kaboutapplicationdialog.cpp d656fa2 
  kdeui/dialogs/kconfigdialogmanager.h ddac3eb 
  kdeui/dialogs/kconfigdialogmanager.cpp 7e8e73f 
  kdeui/dialogs/kshortcutseditor.cpp 5fad58b 
  kdeui/util/kglobalsettings.cpp 5aad31f 
  khtml/css/cssstyleselector.cpp b5eb370 
  khtml/khtml_settings.cpp 5ed0aeb 
  khtml/xml/dom_docimpl.cpp f30b244 
  kio/kfile/kpropertiesdialog.cpp 850a509 
  kio/kssl/ksslcertdialog.cpp 65301a6 
  staging/frameworkintegration/src/platformtheme/CMakeLists.txt 8cc5614 
  staging/frameworkintegration/src/platformtheme/kdeplatformtheme.h 4bd1eae 
  staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp fba7d13 
  staging/frameworkintegration/src/platformtheme/kfontsettingsdata.h PRE-CREATION 
  staging/frameworkintegration/src/platformtheme/kfontsettingsdata.cpp PRE-CREATION 
  staging/kde4attic/src/kcupsoptionsjobwidget_p.cpp 15771ec 
  staging/kde4attic/src/kdatepicker.cpp 8006e31 
  staging/kde4attic/src/kdatetable.cpp 6f1832f 
  staging/kde4support/src/kdeui/kfontcombobox.cpp 7097ec3 
  tier1/kwidgetsaddons/src/kfontchooser.cpp 53a4a90 

Diff: http://git.reviewboard.kde.org/r/111409/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130708/6c3fdde7/attachment.html>