Review Request 110840: Move KFontComboBox to KDE4Support

David Faure faure at kde.org
Sun Jul 7 07:14:55 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110840/#review35678
-----------------------------------------------------------

Ship it!


git diff --cached --find-copies-harder, or git show --find-copies-harder, makes such patches much easier to review.

But anyway, this one is a move-to-kde4support so I suppose not much was changed in the files that were moved.
Proceed.

- David Faure


On July 5, 2013, 7:40 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110840/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 7:40 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Move KFontComboBox to KDE4Support
> 
> Cleanup now redundant kdeui/fonts folder
> 
> 
> Diffs
> -----
> 
>   staging/kde4support/src/kdeui/kfontcombobox.cpp PRE-CREATION 
>   staging/kde4support/src/kdeui/kfontcombobox.h PRE-CREATION 
>   staging/kde4support/src/kdeui/fonthelpers_p.h PRE-CREATION 
>   staging/kde4support/src/kdeui/fonthelpers.cpp PRE-CREATION 
>   kdeui/fonts/sampleedit_p.h bfdb714 
>   staging/kde4support/src/CMakeLists.txt c30e5f5 
>   kdeui/fonts/kfontcombobox.cpp 7097ec3 
>   kdeui/fonts/kfontcombobox.h 536acbe 
>   kdeui/fonts/fonthelpers_p.h 090b99d 
>   kdeui/fonts/fonthelpers.cpp 0906165 
>   kdeui/CMakeLists.txt c7dd8c2 
> 
> Diff: http://git.reviewboard.kde.org/r/110840/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130707/4487a277/attachment.html>


More information about the Kde-frameworks-devel mailing list