Review Request 111171: Deprecate (in)active(Title/Text)Color

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111171/#review35643
-----------------------------------------------------------

Ship it!


Looks good to me. Just add "inactive" / "active" in the docu to differenciate the two.

- David Faure


On July 5, 2013, 4:46 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111171/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 4:46 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Description
> -------
> 
> In the comment we are suggesting a way of getting what probably most developers want from these API (window colors) and additionally a way of continue getting the same values by reading directly the configuration file.
> 
> 
> Diffs
> -----
> 
>   kdeui/util/kglobalsettings.h 074f4f4 
> 
> Diff: http://git.reviewboard.kde.org/r/111171/diff/
> 
> 
> Testing
> -------
> 
> Nothing, only deprecateds have been added.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130705/383481ae/attachment.html>