Review Request 111171: Deprecate (in)active(Title/Text)Color

Àlex Fiestas afiestas at kde.org
Fri Jul 5 16:24:52 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111171/
-----------------------------------------------------------

(Updated July 5, 2013, 4:24 p.m.)


Review request for KDE Frameworks and kdelibs.


Summary (updated)
-----------------

Deprecate (in)active(Title/Text)Color


Description
-------

In the comment we are suggesting a way of getting what probably most developers want from these API (window colors) and additionally a way of continue getting the same values by reading directly the configuration file.


Diffs
-----

  kdeui/util/kglobalsettings.h 4b77ed5 
  khtml/misc/helper.cpp dccb9bf 

Diff: http://git.reviewboard.kde.org/r/111171/diff/


Testing
-------

I have compared the colors returned by the methods before and after this patch, they are close enough.

Additionally used some apps like filelight with the change, and it seems to work for them as well.


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130705/f3adbff7/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list