Review Request 111405: Move KGlobalSettings::createApplicationPalette to KColorScheme

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111405/#review35636
-----------------------------------------------------------

Ship it!


Well done for not listening to my suggestion :-). Indeed, given how tied this is to KColorScheme, it's much better to move it there than to KConfigGui.

Please push after fixing the minor issues below.


staging/kwidgets/src/utils/kcolorscheme.h
<http://git.reviewboard.kde.org/r/111405/#comment26149>

    indentation (one space too many)



staging/kwidgets/src/utils/kcolorscheme.h
<http://git.reviewboard.kde.org/r/111405/#comment26150>

    Remove this comment, it only applied to one of the two overloads.
    
    We are calling this from the QPA itself, not just from config modules.



staging/kwidgets/src/utils/kcolorscheme.h
<http://git.reviewboard.kde.org/r/111405/#comment26148>

    @since 5.0


- David Faure


On July 5, 2013, 2:25 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111405/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 2:25 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> We want to deprecate KGlobalSettings, but we need to keep the createApplicationPalette functionality.
> 
> I decided to move it to KColorScheme. We have 2 kind of users for this method:
> - applications that want to do fancy stuff with KDE and integrate better which will have to depend on KWidgets
> - and the rest, who will be able to rely on a properly set QPalette (by whichever QPlatformTheme we're using on).
> 
> Having moved the method to KColorScheme, seems to me we can use it from our Platform Theme, because it was doing mostly the same.
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kstyle.cpp 9cb0fd2 
>   kdeui/util/kglobalsettings.h 4b77ed5 
>   kdeui/util/kglobalsettings.cpp 3e60632 
>   staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp 7b660f0 
>   staging/kwidgets/src/utils/kcolorscheme.h 3ee47be 
>   staging/kwidgets/src/utils/kcolorscheme.cpp a270878 
> 
> Diff: http://git.reviewboard.kde.org/r/111405/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130705/076f2c75/attachment.html>