Review Request 111298: Add a URL handler for help:/// urls

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111298/#review35504
-----------------------------------------------------------

Ship it!


Just coding style nitpicks. Code logic seems good now :)


staging/kwidgets/src/utils/urlhandler.cpp
<http://git.reviewboard.kde.org/r/111298/#comment26079>

    trailing whitespace :)



staging/kwidgets/src/utils/urlhandler.cpp
<http://git.reviewboard.kde.org/r/111298/#comment26080>

    missing spaces around ==



staging/kwidgets/tests/openurltest.cpp
<http://git.reviewboard.kde.org/r/111298/#comment26081>

    spaces around <=


- David Faure


On July 3, 2013, 10:57 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111298/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 10:57 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Following a task in the kdelibs_cleanup Epics, make it so Qt can properly open help:// urls.
> 
> I added some "magic" query arguments so we can be passed the application in case we want to deprecate KHelpClient::invokeHelp, I'm unsure if we should port the invokeHelp code to call this.
> 
> 
> Diffs
> -----
> 
>   staging/kwidgets/src/utils/urlhandler.cpp PRE-CREATION 
>   staging/kwidgets/src/CMakeLists.txt 4f8dfab 
>   staging/kwidgets/tests/CMakeLists.txt 23d4e4f 
>   staging/kwidgets/tests/openurltest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130703/591617b7/attachment.html>