Review Request 111298: Add a URL handler for help:/// urls

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111298/#review35496
-----------------------------------------------------------


This is much simpler indeed. Too simple? If the app uses help:/, the expansion to help:/appname doesn't happen anymore. Wasn't it supposed to happen here? Surely khelpcenter can't guess who's calling it. Or is it up to khelpmenu and the help button in dialogs, to append the appname? I don't know the full context. I'm just surprised because iirc the earlier version of the patch did that.


staging/kwidgets/src/utils/urlhandler.cpp
<http://git.reviewboard.kde.org/r/111298/#comment26041>

    Not used anymore



staging/kwidgets/src/utils/urlhandler.cpp
<http://git.reviewboard.kde.org/r/111298/#comment26040>

    Not used anymore



staging/kwidgets/src/utils/urlhandler.cpp
<http://git.reviewboard.kde.org/r/111298/#comment26039>

    Not used anymore



staging/kwidgets/src/utils/urlhandler.cpp
<http://git.reviewboard.kde.org/r/111298/#comment26038>

    missing space after if


- David Faure


On July 2, 2013, 6 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111298/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 6 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Following a task in the kdelibs_cleanup Epics, make it so Qt can properly open help:// urls.
> 
> I added some "magic" query arguments so we can be passed the application in case we want to deprecate KHelpClient::invokeHelp, I'm unsure if we should port the invokeHelp code to call this.
> 
> 
> Diffs
> -----
> 
>   staging/kwidgets/src/CMakeLists.txt e337b81 
>   staging/kwidgets/src/utils/urlhandler.cpp PRE-CREATION 
>   staging/kwidgets/tests/CMakeLists.txt f173b80 
>   staging/kwidgets/tests/openurltest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130703/f83ac209/attachment.html>