Review Request 111080: Macro*.cmake changes

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111080/#review35475
-----------------------------------------------------------


Isn't the feature_summary() call missing some arguments ?

- Alexander Neundorf


On July 2, 2013, 1:34 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111080/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 1:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Alexander Neundorf.
> 
> 
> Description
> -------
> 
> MacroAddCompileFlags.cmake
> MacroAddLinkFlags.cmake
> MacroAdditionalCleanFiles.cmake
> MacroEnsureVersion.cmake
> MacroLogFeature.cmake
> MacroOptionalAddSubdirectory.cmake
> MacroOptionalDependPackage.cmake
> MacroOptionalFindPackage.cmake
> MacroPushRequiredVars.cmake
> MacroWriteBasicCMakeVersionFile.cmake
> 
> have been removed.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/CMakeLists.txt 25ea009 
>   cmake/modules/KDE4Macros.cmake 8497e51 
>   cmake/modules/MacroAddCompileFlags.cmake 12038c0 
>   cmake/modules/MacroAddLinkFlags.cmake a10d39e 
>   cmake/modules/MacroAdditionalCleanFiles.cmake 593182f 
>   cmake/modules/MacroEnsureVersion.cmake 6797e5b 
>   cmake/modules/MacroLibrary.cmake 6255f6f 
>   cmake/modules/MacroLogFeature.cmake 631c7ac 
>   cmake/modules/MacroOptionalAddSubdirectory.cmake ec0ea30 
>   cmake/modules/MacroOptionalDependPackage.cmake 2ea7996 
>   cmake/modules/MacroOptionalFindPackage.cmake d4ed48e 
>   cmake/modules/MacroPushRequiredVars.cmake 650b566 
>   cmake/modules/MacroWriteBasicCMakeVersionFile.cmake 6f9e418 
>   experimental/CMakeLists.txt 50efe96 
>   kdecore/localization/ConfigureChecks.cmake bccc1d1 
>   kdeui/CMakeLists.txt 1dcf6db 
>   kdoctools/CMakeLists.txt b7a20da 
>   khtml/java/CMakeLists.txt bb6ab56 
>   kio/CMakeLists.txt 6af7b6d 
>   kio/kio/thumbcreator.h 6cf19d6 
>   kioslave/file/CMakeLists.txt 3237aad 
>   staging/kio/src/core/ConfigureChecks.cmake 7e3dca5 
>   staging/knotifications/src/CMakeLists.txt 72d2999 
> 
> Diff: http://git.reviewboard.kde.org/r/111080/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130702/f722ded4/attachment.html>