Review Request 111191: Move KTextEdit to KTextWidgets

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111191/#review35473
-----------------------------------------------------------

Ship it!


There are a lot of QLatin1String("...") which should probably be QStringLiteral("..."), but I'm not sure it's worth the effort, so just something to keep in mind next time.


kdeui/findreplace/kfinddialog.cpp
<http://git.reviewboard.kde.org/r/111191/#comment26018>

    when using arg(), QString::fromLatin1("foo").arg() is a bit shorter than QString(QLatin1String("foo")).arg()


- David Faure


On July 2, 2013, 5 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111191/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 5 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Move KFind, KFindDialog, KReplace, KReplaceDialog, KTextEdit to KTextWidgets.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt d8b9b53 
>   kdeui/findreplace/kfind.h cf65e39 
>   kdeui/findreplace/kfind.cpp 02e5236 
>   kdeui/findreplace/kfind_p.h 53b9870 
>   kdeui/findreplace/kfinddialog.h 39de50c 
>   kdeui/findreplace/kfinddialog.cpp c760e89 
>   kdeui/findreplace/kfinddialog_p.h 019231f 
>   kdeui/findreplace/kreplace.h a4e2c75 
>   kdeui/findreplace/kreplace.cpp b8d509e 
>   kdeui/findreplace/kreplacedialog.h 2416db1 
>   kdeui/findreplace/kreplacedialog.cpp 0af24ec 
>   kdeui/tests/CMakeLists.txt 6ef234a 
>   kdeui/tests/kfindtest.h  
>   kdeui/tests/kfindtest.cpp 369e6eb 
>   kdeui/tests/kreplacetest.h  
>   kdeui/tests/kreplacetest.cpp 83e00a0 
>   kdeui/tests/ktextedit_unittest.cpp 9d77574 
>   kdeui/tests/ktextedittest.cpp 0509627 
>   kdeui/widgets/ktextedit.h 0a0bbf6 
>   kdeui/widgets/ktextedit.cpp 4605bfd 
>   staging/CMakeLists.txt 9afc80c 
>   staging/ktextwidgets/CMakeLists.txt PRE-CREATION 
>   staging/ktextwidgets/autotests/CMakeLists.txt PRE-CREATION 
>   staging/ktextwidgets/ktextwidgetsConfig.cmake.in PRE-CREATION 
>   staging/ktextwidgets/src/CMakeLists.txt PRE-CREATION 
>   staging/ktextwidgets/tests/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111191/diff/
> 
> 
> Testing
> -------
> 
> Builds and tests passed. kreplacetest segfaults.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130702/77a7dc83/attachment-0001.html>