Review Request 111183: Move KLanguageButton to KWidgets

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111183/#review35468
-----------------------------------------------------------



kdeui/widgets/klanguagebutton.h
<http://git.reviewboard.kde.org/r/111183/#comment26005>

    The docu needs adjusting. The default is now QLocale::system().name().



kdeui/widgets/klanguagebutton.cpp
<http://git.reviewboard.kde.org/r/111183/#comment26006>

    (while you're making changes there, adapt to kdelibs coding style: 
        setLocale(const QString &locale)
    )



kdeui/widgets/klanguagebutton.cpp
<http://git.reviewboard.kde.org/r/111183/#comment26007>

    Isn't that the same as setCurrentItem(d->locale) ?


- David Faure


On July 2, 2013, 4:44 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111183/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 4:44 p.m.)
> 
> 
> Review request for KDE Frameworks and Kevin Ottens.
> 
> 
> Description
> -------
> 
> * Move KLanguageButton to KWidgets
> * Ported to QLocale
> 
> 
> Diffs
> -----
> 
>   staging/kwidgets/src/CMakeLists.txt e337b81 
>   kdeui/widgets/klanguagebutton.cpp c5d8e4b 
>   kdeui/widgets/klanguagebutton.h feb2b5b 
>   kdeui/CMakeLists.txt d8b9b53 
> 
> Diff: http://git.reviewboard.kde.org/r/111183/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130702/d40c2b29/attachment.html>