Review Request 111183: Move KLanguageButton to KWidgets

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111183/#review35455
-----------------------------------------------------------



staging/kwidgets/src/widgets/klanguagebutton.cpp
<http://git.reviewboard.kde.org/r/111183/#comment25968>

    What's the 0 for?
    QLocale(0) seems strange, I wonder how it even compiles.



staging/kwidgets/src/widgets/klanguagebutton.cpp
<http://git.reviewboard.kde.org/r/111183/#comment25973>

    Am I right that this is the only use of the d->locale member?
    
    In that case, it seems to me that it would be much better to just take a QString in the API (rather than a QLocale), and let the caller call .name() if he has a QLocale.
    This makes the class independent from QLocale (at least API-wise) ... well, just in case.
    
    Lesson learned from KDE4's KComponentData I guess: not depending on an object, just to extract one QString from it.
    


- David Faure


On July 2, 2013, 4:04 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111183/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 4:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Kevin Ottens.
> 
> 
> Description
> -------
> 
> * Move KLanguageButton to KWidgets
> * Ported to QLocale
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt d8b9b53 
>   kdeui/widgets/klanguagebutton.h feb2b5b 
>   kdeui/widgets/klanguagebutton.cpp c5d8e4b 
>   staging/kwidgets/src/CMakeLists.txt e337b81 
> 
> Diff: http://git.reviewboard.kde.org/r/111183/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130702/f86aef27/attachment.html>