Review Request 111210: Move KHelpMenu and friends to XmlGui

Andrea Scarpino scarpino at kde.org
Tue Jul 2 14:20:22 UTC 2013 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111210/
-----------------------------------------------------------

(Updated July 2, 2013, 4:20 p.m.)


Review request for KDE Frameworks.


Changes
-------

Updated after Apol changes in kswitchlanguagedialog_p.


Description
-------

Move:
* KAboutApplicationDialog
* KBugReport
* KHelpMenu
* KShortcutsEditor
* KShortcutsDialog
* KEditToolBar
* KShortcutWidget
* KKeySequenceWidget
* KXmlGuiClient
* KXmlGuiFactory
* KXmlGuiBuilder
* KMainWindow
* KToolBar
* KActionCollection
* KToggleBarAction
* KActionCategory
to XmlGui.

Notes:
 * the code that uses KLocale has been commented; waiting for review https://git.reviewboard.kde.org/r/111178/
 * the code that uses KGestureMap has been commented. What to do?
 * the code that uses KGlobalSettings has been commented. Waiting for a decision to be taken in the thread http://lists.kde.org/?l=kde-frameworks-devel&m=137149104802300&w=2

Needs https://git.reviewboard.kde.org/r/111191/


Diffs (updated)
-----

  kdeui/dialogs/kshortcutseditoritem.cpp 3be65ef 
  kdeui/dialogs/kswitchlanguagedialog_p.h 64151b5 
  kdeui/dialogs/kswitchlanguagedialog_p.cpp 466d8dc 
  kdeui/kdepackages.h 41f01fa 
  kdeui/make_kdepackages.sh b3ed36b 
  kdeui/make_kdepackages_updated.py e503390 
  kdeui/shortcuts/kshortcutschemeshelper.cpp 1ea1631 
  kdeui/shortcuts/kshortcutschemeshelper_p.h a185a88 
  kdeui/dialogs/kshortcutseditordelegate.cpp 53c619c 
  kdeui/dialogs/kshortcutseditor.cpp 5fad58b 
  kdeui/dialogs/kshortcutseditor.h 5b7e24a 
  kdeui/dialogs/kshortcutsdialog_p.h 78067fa 
  kdeui/dialogs/kshortcutsdialog.ui bf50472 
  kdeui/dialogs/kshortcutsdialog.cpp 1a187b3 
  kdeui/dialogs/kshortcutsdialog.h 54082f9 
  kdeui/dialogs/kshortcutschemeseditor.cpp 095aeeb 
  kdeui/dialogs/kshortcuteditwidget.cpp 228a401 
  kdeui/dialogs/kedittoolbar_p.h c6436d2 
  kdeui/dialogs/kedittoolbar.cpp b4fb8cb 
  kdeui/dialogs/kedittoolbar.h 217c3c6 
  kdeui/dialogs/kbugreport.cpp cf56aa3 
  kdeui/dialogs/kbugreport.h c3ace5e 
  kdeui/dialogs/kaboutkdedialog_p.cpp 35061f6 
  kdeui/dialogs/kaboutkdedialog_p.h 894dff8 
  kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp 25d2765 
  kdeui/dialogs/kaboutapplicationpersonmodel_p.h 5001da8 
  kdeui/dialogs/kaboutapplicationpersonlistview_p.cpp 6bd59b5 
  kdeui/dialogs/kaboutapplicationpersonlistview_p.h f580509 
  kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp 8933202 
  kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.h 0e32591 
  kdeui/dialogs/kaboutapplicationdialog.cpp d656fa2 
  kdeui/dialogs/kaboutapplicationdialog.h 7459f7e 
  kdeui/dialogs/kaboutapplicationconfigattica_p.h.cmake d0c8ae7 
  kdeui/actions/ktoggletoolbaraction.cpp 5db4192 
  kdeui/actions/ktoggletoolbaraction.h e937ba3 
  kdeui/actions/kactioncollection.cpp 7dc2987 
  kdeui/actions/kactioncollection.h 8ca6845 
  kdeui/actions/kactioncategory.cpp 5365def 
  kdeui/CMakeLists.txt d8b9b53 
  kdeui/actions/kactioncategory.h 25f3be8 
  kdeui/tests/CMakeLists.txt 6ef234a 
  kdeui/tests/kactioncategorytest.h 62152d1 
  kdeui/tests/kactioncategorytest.cpp 2e30b0c 
  kdeui/tests/kbugreporttest.cpp cd71173 
  kdeui/tests/kmainwindow_unittest.h 0f84b31 
  kdeui/tests/kmainwindow_unittest.cpp 2bc4665 
  kdeui/tests/kmainwindowrestoretest.h 7bd535f 
  kdeui/tests/kmainwindowrestoretest.cpp 95146a2 
  kdeui/tests/kmainwindowtest.h 786f490 
  kdeui/tests/kmainwindowtest.cpp 3deac97 
  kdeui/tests/ktoolbar_unittest.cpp 4e1431b 
  kdeui/tests/ktoolbartest.cpp 25c0598 
  kdeui/tests/kxmlgui_unittest.h fa2d7fb 
  kdeui/tests/kxmlgui_unittest.cpp cf99a0a 
  kdeui/tests/kxmlguitest.h 87087e1 
  kdeui/tests/kxmlguitest.cpp cc8d9d3 
  kdeui/tests/kxmlguitest_part.rc 84f5e4f 
  kdeui/tests/kxmlguitest_shell.rc e6c3999 
  kdeui/tests/kxmlguiwindowtest.cpp ac484e2 
  kdeui/tests/kxmlguiwindowtestui.rc 92a2a5c 
  kdeui/tests/testguiclient.h f10207e 
  kdeui/tests/testxmlguiwindow.h 0ac78fe 
  kdeui/widgets/khelpmenu.h 9210810 
  kdeui/widgets/khelpmenu.cpp 24e44db 
  kdeui/widgets/kkeysequencewidget.h 6ea1b5a 
  kdeui/widgets/kkeysequencewidget.cpp 235353f 
  kdeui/widgets/kkeysequencewidget_p.h 72d21af 
  kdeui/widgets/kshortcutwidget.h 18ec960 
  kdeui/widgets/kshortcutwidget.cpp 52e1440 
  kdeui/widgets/kshortcutwidget.ui 7737ce7 
  kdeui/xmlgui/kmainwindow.h 32e37cf 
  kdeui/xmlgui/kmainwindow.cpp e7f2d31 
  kdeui/xmlgui/kmainwindow_p.h 92646f3 
  kdeui/xmlgui/kmainwindowiface.cpp 6c77d93 
  kdeui/xmlgui/kmainwindowiface_p.h b59b2b1 
  kdeui/xmlgui/kmenumenuhandler_p.h 2af112a 
  kdeui/xmlgui/kmenumenuhandler_p.cpp 27cd5c3 
  kdeui/xmlgui/ktoolbar.h 94f5c81 
  kdeui/xmlgui/ktoolbar.cpp 8157bb4 
  kdeui/xmlgui/ktoolbarhandler.cpp 1ad8da6 
  kdeui/xmlgui/ktoolbarhandler_p.h d0cd9af 
  kdeui/xmlgui/kxmlguibuilder.h e841384 
  kdeui/xmlgui/kxmlguibuilder.cpp 04d760c 
  kdeui/xmlgui/kxmlguiclient.h 3b06b50 
  kdeui/xmlgui/kxmlguiclient.cpp 96ea35b 
  kdeui/xmlgui/kxmlguifactory.h c6e853b 
  kdeui/xmlgui/kxmlguifactory.cpp 272b010 
  kdeui/xmlgui/kxmlguifactory_p.h 8854dea 
  kdeui/xmlgui/kxmlguifactory_p.cpp 42b97d4 
  kdeui/xmlgui/kxmlguiversionhandler.cpp 3e6227b 
  kdeui/xmlgui/kxmlguiversionhandler_p.h add736b 
  kdeui/xmlgui/kxmlguiwindow.h 218cd77 
  kdeui/xmlgui/kxmlguiwindow.cpp a74eece 
  staging/xmlgui/CMakeLists.txt 6320a19 
  staging/xmlgui/autotests/CMakeLists.txt 83c2b11 
  staging/xmlgui/autotests/kactioncategorytest.h PRE-CREATION 
  staging/xmlgui/autotests/kactioncategorytest.cpp PRE-CREATION 
  staging/xmlgui/autotests/kmainwindow_unittest.h PRE-CREATION 
  staging/xmlgui/autotests/kmainwindow_unittest.cpp PRE-CREATION 
  staging/xmlgui/autotests/ktoolbar_unittest.cpp PRE-CREATION 
  staging/xmlgui/autotests/kxmlgui_unittest.h PRE-CREATION 
  staging/xmlgui/autotests/kxmlgui_unittest.cpp PRE-CREATION 
  staging/xmlgui/autotests/testguiclient.h PRE-CREATION 
  staging/xmlgui/autotests/testxmlguiwindow.h PRE-CREATION 
  staging/xmlgui/make_kdepackages.sh PRE-CREATION 
  staging/xmlgui/make_kdepackages_updated.py PRE-CREATION 
  staging/xmlgui/src/CMakeLists.txt a506ab0 
  staging/xmlgui/src/config-xmlgui.h.cmake 58949d8 
  staging/xmlgui/src/kaboutapplicationconfigattica_p.h.cmake PRE-CREATION 
  staging/xmlgui/src/kaboutapplicationdialog.h PRE-CREATION 
  staging/xmlgui/src/kaboutapplicationdialog.cpp PRE-CREATION 
  staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.h PRE-CREATION 
  staging/xmlgui/src/kaboutapplicationpersonlistdelegate_p.cpp PRE-CREATION 
  staging/xmlgui/src/kaboutapplicationpersonlistview_p.h PRE-CREATION 
  staging/xmlgui/src/kaboutapplicationpersonlistview_p.cpp PRE-CREATION 
  staging/xmlgui/src/kaboutapplicationpersonmodel_p.h PRE-CREATION 
  staging/xmlgui/src/kaboutapplicationpersonmodel_p.cpp PRE-CREATION 
  staging/xmlgui/src/kaboutkdedialog_p.h PRE-CREATION 
  staging/xmlgui/src/kaboutkdedialog_p.cpp PRE-CREATION 
  staging/xmlgui/src/kactioncategory.h PRE-CREATION 
  staging/xmlgui/src/kactioncategory.cpp PRE-CREATION 
  staging/xmlgui/src/kactioncollection.h PRE-CREATION 
  staging/xmlgui/src/kactioncollection.cpp PRE-CREATION 
  staging/xmlgui/src/kbugreport.h PRE-CREATION 
  staging/xmlgui/src/kbugreport.cpp PRE-CREATION 
  staging/xmlgui/src/kdepackages.h PRE-CREATION 
  staging/xmlgui/src/kedittoolbar.h PRE-CREATION 
  staging/xmlgui/src/kedittoolbar.cpp PRE-CREATION 
  staging/xmlgui/src/kedittoolbar_p.h PRE-CREATION 
  staging/xmlgui/src/khelpmenu.h PRE-CREATION 
  staging/xmlgui/src/khelpmenu.cpp PRE-CREATION 
  staging/xmlgui/src/kkeysequencewidget.h PRE-CREATION 
  staging/xmlgui/src/kkeysequencewidget.cpp PRE-CREATION 
  staging/xmlgui/src/kkeysequencewidget_p.h PRE-CREATION 
  staging/xmlgui/src/kmainwindow.h PRE-CREATION 
  staging/xmlgui/src/kmainwindow.cpp PRE-CREATION 
  staging/xmlgui/src/kmainwindow_p.h PRE-CREATION 
  staging/xmlgui/src/kmainwindowiface.cpp PRE-CREATION 
  staging/xmlgui/src/kmainwindowiface_p.h PRE-CREATION 
  staging/xmlgui/src/kmenumenuhandler_p.h PRE-CREATION 
  staging/xmlgui/src/kmenumenuhandler_p.cpp PRE-CREATION 
  staging/xmlgui/src/kshortcuteditwidget.cpp PRE-CREATION 
  staging/xmlgui/src/kshortcutschemeseditor.cpp PRE-CREATION 
  staging/xmlgui/src/kshortcutschemeshelper.cpp PRE-CREATION 
  staging/xmlgui/src/kshortcutschemeshelper_p.h PRE-CREATION 
  staging/xmlgui/src/kshortcutsdialog.h PRE-CREATION 
  staging/xmlgui/src/kshortcutsdialog.cpp PRE-CREATION 
  staging/xmlgui/src/kshortcutsdialog.ui PRE-CREATION 
  staging/xmlgui/src/kshortcutsdialog_p.h PRE-CREATION 
  staging/xmlgui/src/kshortcutseditor.h PRE-CREATION 
  staging/xmlgui/src/kshortcutseditor.cpp PRE-CREATION 
  staging/xmlgui/src/kshortcutseditordelegate.cpp PRE-CREATION 
  staging/xmlgui/src/kshortcutseditoritem.cpp PRE-CREATION 
  staging/xmlgui/src/kshortcutwidget.h PRE-CREATION 
  staging/xmlgui/src/kshortcutwidget.cpp PRE-CREATION 
  staging/xmlgui/src/kshortcutwidget.ui PRE-CREATION 
  staging/xmlgui/src/kswitchlanguagedialog_p.h PRE-CREATION 
  staging/xmlgui/src/kswitchlanguagedialog_p.cpp PRE-CREATION 
  staging/xmlgui/src/ktoggletoolbaraction.h PRE-CREATION 
  staging/xmlgui/src/ktoggletoolbaraction.cpp PRE-CREATION 
  staging/xmlgui/src/ktoolbar.h PRE-CREATION 
  staging/xmlgui/src/ktoolbar.cpp PRE-CREATION 
  staging/xmlgui/src/ktoolbarhandler.cpp PRE-CREATION 
  staging/xmlgui/src/ktoolbarhandler_p.h PRE-CREATION 
  staging/xmlgui/src/kxmlguibuilder.h PRE-CREATION 
  staging/xmlgui/src/kxmlguibuilder.cpp PRE-CREATION 
  staging/xmlgui/src/kxmlguiclient.h PRE-CREATION 
  staging/xmlgui/src/kxmlguiclient.cpp PRE-CREATION 
  staging/xmlgui/src/kxmlguifactory.h PRE-CREATION 
  staging/xmlgui/src/kxmlguifactory.cpp PRE-CREATION 
  staging/xmlgui/src/kxmlguifactory_p.h PRE-CREATION 
  staging/xmlgui/src/kxmlguifactory_p.cpp PRE-CREATION 
  staging/xmlgui/src/kxmlguiversionhandler.cpp PRE-CREATION 
  staging/xmlgui/src/kxmlguiversionhandler_p.h PRE-CREATION 
  staging/xmlgui/src/kxmlguiwindow.h PRE-CREATION 
  staging/xmlgui/src/kxmlguiwindow.cpp PRE-CREATION 
  staging/xmlgui/tests/CMakeLists.txt dce637f 
  staging/xmlgui/tests/kbugreporttest.cpp PRE-CREATION 
  staging/xmlgui/tests/kmainwindowrestoretest.h PRE-CREATION 
  staging/xmlgui/tests/kmainwindowrestoretest.cpp PRE-CREATION 
  staging/xmlgui/tests/kmainwindowtest.h PRE-CREATION 
  staging/xmlgui/tests/kmainwindowtest.cpp PRE-CREATION 
  staging/xmlgui/tests/ktoolbartest.cpp PRE-CREATION 
  staging/xmlgui/tests/kxmlguitest.h PRE-CREATION 
  staging/xmlgui/tests/kxmlguitest.cpp PRE-CREATION 
  staging/xmlgui/tests/kxmlguitest_part.rc PRE-CREATION 
  staging/xmlgui/tests/kxmlguitest_shell.rc PRE-CREATION 
  staging/xmlgui/tests/kxmlguiwindowtest.cpp PRE-CREATION 
  staging/xmlgui/tests/kxmlguiwindowtestui.rc PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111210/diff/


Testing
-------

Builds.
Several {auto,}tests segfaults.


Thanks,

Andrea Scarpino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130702/9b3a65f3/attachment-0001.html>

More information about the Kde-frameworks-devel mailing list