Review Request 111298: Add a URL handler for help:/// urls

[Aleix Pol Gonzalez]

> On July 2, 2013, 8:35 a.m., Kevin Ottens wrote:
> > staging/kwidgets/src/urlhandler.cpp, line 44
> > <http://git.reviewboard.kde.org/r/111298/diff/3/?file=166986#file166986line44>
> >
> >     Well, this whole block creates such a help:/foo and then calls QDesktopService::openUrl again with the newly built URL.
> >     
> >     Which indeed makes me wonder what happens to said URL... Who handles it if it's not in this code?

It's called by xdg-open, which is what was happening from KHelpClient.

Should I change it to run the khelpcenter <url>?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111298/#review35425
-----------------------------------------------------------


On July 1, 2013, 5:13 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111298/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 5:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Following a task in the kdelibs_cleanup Epics, make it so Qt can properly open help:// urls.
> 
> I added some "magic" query arguments so we can be passed the application in case we want to deprecate KHelpClient::invokeHelp, I'm unsure if we should port the invokeHelp code to call this.
> 
> 
> Diffs
> -----
> 
>   staging/kwidgets/src/CMakeLists.txt e337b81 
>   staging/kwidgets/src/urlhandler.cpp PRE-CREATION 
>   staging/kwidgets/tests/CMakeLists.txt f173b80 
>   staging/kwidgets/tests/openurltest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130702/1aac9669/attachment.html>