Review Request 111183: Move KLanguageButton to KWidgets
Andrea Scarpino
scarpino at kde.org
Tue Jul 2 09:07:52 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111183/
-----------------------------------------------------------
(Updated July 2, 2013, 11:07 a.m.)
Review request for KDE Frameworks and Kevin Ottens.
Changes
-------
Drop KLocale
Description
-------
The KLocate code is commented. I don't know if this is OK, or if I've to port it to QLocale first and then it can be moved to kwidgets.
This patch must be applied with the others 2 that I'm going to push later.
KHelpMenu uses KLanguageButton through KSwitchLanguageDialogPrivate.
Diffs (updated)
-----
kdeui/CMakeLists.txt abc7a2d
kdeui/widgets/klanguagebutton.h feb2b5b
kdeui/widgets/klanguagebutton.cpp c5d8e4b
staging/kwidgets/src/CMakeLists.txt e337b81
staging/kwidgets/src/widgets/klanguagebutton.h PRE-CREATION
staging/kwidgets/src/widgets/klanguagebutton.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111183/diff/
Testing
-------
Builds.
Thanks,
Andrea Scarpino
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130702/d84d2e9e/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list