Review Request 111298: Add a URL handler for help:/// urls

[Kevin Ottens]

> On July 1, 2013, 8:01 p.m., David Gil Oliva wrote:
> > staging/kwidgets/src/urlhandler.cpp, line 59
> > <http://git.reviewboard.kde.org/r/111298/diff/3/?file=166986#file166986line59>
> >
> >     const QString& dir -> const QString &dir
> >     
> >     From the kdelibs coding style: http://techbase.kde.org/Policies/Kdelibs_Coding_Style#Whitespace (not that I'm inventing it, though perhaps I'm being too picky...)
> >
> 
> David Faure wrote:
>     Technically you're right. But I admit we have never really enforced that one in kdelibs the way Qt does. I'm only starting to put the '&' or '*' on the "right" side now that I'm contributing to Qt :)
>     I don't think we should be delaying any "ship it" for this particular whitespace issue.
>

It's good that we take the habit properly in reviews starting now though.

Right now it's "not so much of a problem" because we're inconsistent "anyway", but that won't makes us closer to being consistent if we keep being sloppy on that.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111298/#review35401
-----------------------------------------------------------


On July 1, 2013, 5:13 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111298/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 5:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Following a task in the kdelibs_cleanup Epics, make it so Qt can properly open help:// urls.
> 
> I added some "magic" query arguments so we can be passed the application in case we want to deprecate KHelpClient::invokeHelp, I'm unsure if we should port the invokeHelp code to call this.
> 
> 
> Diffs
> -----
> 
>   staging/kwidgets/src/CMakeLists.txt e337b81 
>   staging/kwidgets/src/urlhandler.cpp PRE-CREATION 
>   staging/kwidgets/tests/CMakeLists.txt f173b80 
>   staging/kwidgets/tests/openurltest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130702/740d27a5/attachment.html>