Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111171/#review35358
-----------------------------------------------------------



kdeui/util/kglobalsettings.h
<http://git.reviewboard.kde.org/r/111171/#comment25905>

    I think it's fine. lxr.kde.org seem to indicate that those colors got abused at some places anyway, and what's proposed here seems like a proper replacement to me (except if you're kwin of course, but I think the people behind it know that by now).



khtml/misc/helper.cpp
<http://git.reviewboard.kde.org/r/111171/#comment25906>

    Why unrelated?
    
    It's removing calls to the newly deprecated API from KHTML (one of the abusers from my previous comment). Could be made in a separate commit indeed, but for review purpose it seems relevant to the topic for me.


- Kevin Ottens


On June 28, 2013, 5:10 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111171/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 5:10 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Description
> -------
> 
> Deprecate: inactiveTitleColor, inactiveTextColor, activeTitleColor, activeTextColor in favor of KColorScheme and replace the implementation of those methods with it.
> 
> 
> Diffs
> -----
> 
>   kdeui/util/kglobalsettings.h 4b77ed5 
>   khtml/misc/helper.cpp dccb9bf 
> 
> Diff: http://git.reviewboard.kde.org/r/111171/diff/
> 
> 
> Testing
> -------
> 
> I have compared the colors returned by the methods before and after this patch, they are close enough.
> 
> Additionally used some apps like filelight with the change, and it seems to work for them as well.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130701/6a0442ba/attachment.html>