Review Request 111246: Port time_t to QDateTime in Ftp (kioslave)
Kevin Ottens
ervin at kde.org
Mon Jul 1 14:31:26 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111246/#review35356
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On June 27, 2013, 9:45 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111246/
> -----------------------------------------------------------
>
> (Updated June 27, 2013, 9:45 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Port time_t to QDateTime in Ftp (kioslave)
>
> It was less work than previously thought. Although I previously
> thought about substituting the const *chars to QByteArrays,
> I will not do it because "if it works, don't touch it!"...
>
>
> Diffs
> -----
>
> kioslave/ftp/ftp.h 218b3578bd4649ab2ed332ec66a1ac0910d0e379
> kioslave/ftp/ftp.cpp 3de1aa36bf3664f669e4d2fbe63b571cca1c36f5
>
> Diff: http://git.reviewboard.kde.org/r/111246/diff/
>
>
> Testing
> -------
>
> It builds.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130701/cb05bcf4/attachment.html>
More information about the Kde-frameworks-devel
mailing list