Review Request 111270: move kmodifierkeyinfo to KGuiAddons framework
Kevin Ottens
ervin at kde.org
Mon Jul 1 14:29:29 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111270/#review35355
-----------------------------------------------------------
Note that a second patch to solve the TODO in the CMakeLists.txt would be nice. ;-)
- Kevin Ottens
On June 27, 2013, 9:22 p.m., Wojciech Kapuscinski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111270/
> -----------------------------------------------------------
>
> (Updated June 27, 2013, 9:22 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> move kmodifierkeyinfo to KGuiAddons framework
>
>
> Diffs
> -----
>
> kdeui/CMakeLists.txt ab43f17
> kdeui/tests/CMakeLists.txt f489b6b
> kdeui/tests/kmodifierkeyinfotest.cpp
> kdeui/util/kmodifierkeyinfo.h eeb9291
> kdeui/util/kmodifierkeyinfo.cpp
> kdeui/util/kmodifierkeyinfoprovider.cpp
> kdeui/util/kmodifierkeyinfoprovider_dummy.cpp
> kdeui/util/kmodifierkeyinfoprovider_p.h 636301f
> kdeui/util/kmodifierkeyinfoprovider_x11.cpp
> staging/kguiaddons/src/CMakeLists.txt a6ad2ad
> staging/kguiaddons/tests/CMakeLists.txt PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/111270/diff/
>
>
> Testing
> -------
>
> it builds
>
>
> Thanks,
>
> Wojciech Kapuscinski
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130701/d836f3d7/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list