Review Request 108495: Port kimgio to Qt5

[Allan Sandfeld Jensen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108495/#review25902
-----------------------------------------------------------


In the JSON files you need one mimetype for each key. A plugin can for instance support multiple formats that has different keys and mimetypes. Qt maps the keys and mimetypes by the order.

You could also get rid of the different case keys though.

- Allan Sandfeld Jensen


On Jan. 21, 2013, 12:20 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108495/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2013, 12:20 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Complete port of all kimgio to Qt5, including the json metadata and some minor code cleanup.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0a67fe8 
>   kimgio/CMakeLists.txt 2e4f20e 
>   kimgio/dds.h 4c269ce 
>   kimgio/dds.cpp 0090703 
>   kimgio/dds.json PRE-CREATION 
>   kimgio/eps.h 0f01310 
>   kimgio/eps.cpp c3e6f1d 
>   kimgio/eps.json PRE-CREATION 
>   kimgio/exr.h fa7e646 
>   kimgio/exr.cpp 7361ac4 
>   kimgio/exr.json PRE-CREATION 
>   kimgio/jp2.h 4daffcc 
>   kimgio/jp2.cpp b28c2a2 
>   kimgio/jp2.json PRE-CREATION 
>   kimgio/pcx.h 57059e7 
>   kimgio/pcx.cpp 4237966 
>   kimgio/pcx.json PRE-CREATION 
>   kimgio/pic.h PRE-CREATION 
>   kimgio/pic.cpp PRE-CREATION 
>   kimgio/pic.json PRE-CREATION 
>   kimgio/pic_io_handler.h e81ec19 
>   kimgio/pic_io_handler.cpp b2e7c1d 
>   kimgio/pic_io_plugin.h 1701b27 
>   kimgio/pic_io_plugin.cpp 3328d24 
>   kimgio/psd.h 606d2de 
>   kimgio/psd.cpp 52dcebf 
>   kimgio/psd.json PRE-CREATION 
>   kimgio/ras.h 7603185 
>   kimgio/ras.cpp f056c54 
>   kimgio/ras.json PRE-CREATION 
>   kimgio/rgb.h 9c41190 
>   kimgio/rgb.cpp 49b500f 
>   kimgio/rgb.json PRE-CREATION 
>   kimgio/tga.h 6421e9e 
>   kimgio/tga.cpp c6f1599 
>   kimgio/tga.json PRE-CREATION 
>   kimgio/xcf.h ffdc0f0 
>   kimgio/xcf.cpp 2b782be 
>   kimgio/xcf.json PRE-CREATION 
>   kimgio/xview.h 7ae9a2c 
>   kimgio/xview.cpp 960bc22 
>   kimgio/xview.json PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108495/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130121/762b3b2e/attachment-0001.html>