Review Request 108487: Make kjsembed build on Qt5 rather than on Qt4

[Stephen Kelly]

> On Jan. 20, 2013, 7:04 p.m., Stephen Kelly wrote:
> > kjsembed/kjsembed/slotproxy.cpp, line 68
> > <http://git.reviewboard.kde.org/r/108487/diff/2/?file=108067#file108067line68>
> >
> >     Is this the common way to get at that stuff now? In Qt itself I mean.
> 
> Jon Severinsson wrote:
>     No, in Qt itself staticMetaObects are created by moc-generated code, which uses Q_STATIC_BYTE_ARRAY_DATA_HEADER_INITIALIZER_WITH_OFFSET.
>     That only works on string literals however, and SlotProxy is dynamically generating the data we are putting in the staticMetaObect...
>

I'm not sure we're talking about the same thing. You seem to be talking about static metaobjects as generated by moc. I'm talking about dynamic metaobjects.

There's a QMetaObjectBuilder class which QtQml uses to create dynamic metaobjects. I think that class should become public in Qt 5.1 (or maybe later), and if so, then using that would be the right approach (yes, I know it is more work).


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108487/#review25865
-----------------------------------------------------------


On Jan. 19, 2013, 10:29 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108487/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 10:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> As we are dropping Qt4 support, it's time to port the last pieces of Qt4 only code, even if that makes it Qt5 only...
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0a67fe8 
>   kjsembed/kjsembed/kjsembed.cpp 5dfa804 
>   kjsembed/kjsembed/slotproxy.cpp 59b29d2 
> 
> Diff: http://git.reviewboard.kde.org/r/108487/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130121/e40157c3/attachment.html>