Review Request 108495: Make kimgio compile on Qt5

[Stephen Kelly]

> On Jan. 19, 2013, 11:16 p.m., Christoph Feck wrote:
> > As far as I know, you need to add some JSON stuff to make plugins work with Qt 5.

The JSON file is optional, but you do need to use the Q_PLUGIN_METADATA macro.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108495/#review25815
-----------------------------------------------------------


On Jan. 19, 2013, 10:57 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108495/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 10:57 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> The plugins are still pretty useless without Q_EXPORT_PLUGIN2, but that is in no way unique to kimgio, and at least compiling is an improvement in code coverage...
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0a67fe8 
>   kimgio/dds.cpp 0090703 
>   kimgio/eps.cpp c3e6f1d 
>   kimgio/exr.cpp 7361ac4 
>   kimgio/jp2.cpp b28c2a2 
>   kimgio/pcx.cpp 4237966 
>   kimgio/pic_io_plugin.cpp 3328d24 
>   kimgio/psd.cpp 52dcebf 
>   kimgio/ras.cpp f056c54 
>   kimgio/rgb.cpp 49b500f 
>   kimgio/tga.cpp c6f1599 
>   kimgio/xcf.cpp 2b782be 
>   kimgio/xview.cpp 960bc22 
> 
> Diff: http://git.reviewboard.kde.org/r/108495/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130121/320f5581/attachment.html>