Review Request 108389: Respect the HOME environment variable

[Jon Severinsson]

> On Jan. 19, 2013, 2:15 p.m., Oswald Buddenhagen wrote:
> > fwiw, we have a similar problem in kconfig (iirc).

I think that problem is the opposite. From my reading of the code it seams to use qgetenv("HOME"), falling back on QDir::homePath(), which is implemented by qgetenv("HOME"), falling back on "/"...


- Jon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108389/#review25789
-----------------------------------------------------------


On Jan. 19, 2013, 10:52 a.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108389/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 10:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Oswald Buddenhagen.
> 
> 
> Description
> -------
> 
> This turns KUser::homeDir (and thus KShell::tildeExpand) closer to
> QDir::homePath, which only consults the environment variable.
> 
> It will therefore also fix the kdecore-kshelltest test when HOME is set to a different directory.
> 
> 
> Diffs
> -----
> 
>   kdecore/util/kuser_unix.cpp 6a612a6 
> 
> Diff: http://git.reviewboard.kde.org/r/108389/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130119/97805f79/attachment.html>