Review Request 108487: Make kjsembed build on Qt5 rather than on Qt4
Stephen Kelly
steveire at gmail.com
Sat Jan 19 16:29:42 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108487/#review25797
-----------------------------------------------------------
CMakeLists.txt
<http://git.reviewboard.kde.org/r/108487/#comment19713>
If it requires Qt5UiTools to work, then check for it.
All positive checks for QT5_BUILD are now redundant, so you can remove them.
- Stephen Kelly
On Jan. 19, 2013, 12:54 p.m., Jon Severinsson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108487/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2013, 12:54 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> As we are dropping Qt4 support, it's time to port the last pieces of Qt4 only code, even if that makes it Qt5 only...
>
>
> Diffs
> -----
>
> CMakeLists.txt ce54a6e
> kjsembed/kjsembed/kjsembed.cpp 5dfa804
> kjsembed/kjsembed/slotproxy.cpp 20f55b0
>
> Diff: http://git.reviewboard.kde.org/r/108487/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jon Severinsson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130119/eba30a06/attachment.html>
More information about the Kde-frameworks-devel
mailing list