Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest
Commit Hook
null at kde.org
Mon Jan 14 16:19:38 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108385/#review25500
-----------------------------------------------------------
This review has been submitted with commit 21cd5afbbaac273774259f6c23a79b227e21d3f5 by Jon Severinsson to branch frameworks.
- Commit Hook
On Jan. 13, 2013, 1:03 p.m., Jon Severinsson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108385/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2013, 1:03 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Increase timeout, and sleep a while after waitForReadyRead() returns,
> as it only guarantees that *some* data is available to read, while
> the test assumes that a full line of data is available to read...
>
> This reduces failure rate from 10% to 2% on my setup.
>
>
> Diffs
> -----
>
> kpty/tests/kptyprocesstest.cpp b95ae26
>
> Diff: http://git.reviewboard.kde.org/r/108385/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jon Severinsson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130114/b2067523/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list