Review Request 108389: Respect the HOME environment variable

[Jon Severinsson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108389/
-----------------------------------------------------------

(Updated Jan. 14, 2013, 3:59 p.m.)


Review request for KDE Frameworks.


Changes
-------

> Eek, that's 5 duplicates of the same 4 lines of code.
Actually only 4 copies, the first one is slightly different...

> Can't this be done in the Private constructor?
Sure it can, but unless we want a big mess of argument passing and separate code paths, it need to do additional system calls for each new KUser object, which on some architectures are quite expensive.


Description
-------

This turns KUser::homeDir (and thus KShell::tildeExpand) closer to
QDir::homePath, which only consults the environment variable.

It will therefore also fix the kdecore-kshelltest test when HOME is set to a different directory.


Diffs (updated)
-----

  kdecore/util/kuser_unix.cpp 6a612a6 

Diff: http://git.reviewboard.kde.org/r/108389/diff/


Testing
-------


Thanks,

Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130114/f10df62d/attachment.html>