Review Request 108389: Respect the HOME environment variable

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108389/#review25386
-----------------------------------------------------------


Hmm, can't this code be called for other users than the current user? In that case, $HOME would be really wrong to look at....
Seems to me that looking at $HOME should be done only when looking up the current user, possibly higher up in the call stack.

- David Faure


On Jan. 13, 2013, 1:35 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108389/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 1:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> This turns KUser::homeDir (and thus KShell::tildeExpand) closer to
> QDir::homePath, which only consults the environment variable.
> 
> It will therefore also fix the kdecore-kshelltest test when HOME is set to a different directory.
> 
> 
> Diffs
> -----
> 
>   kdecore/util/kuser_unix.cpp 6a612a6 
> 
> Diff: http://git.reviewboard.kde.org/r/108389/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130113/7152389a/attachment.html>