Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

Jon Severinsson jon at severinsson.net
Sun Jan 13 11:57:33 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108385/
-----------------------------------------------------------

Review request for KDE Frameworks.


Description
-------

Increase timeout, and sleep a while after waitForReadyRead() returns,
as it only guarantees that *some* data is available to read, while
the test assumes that *all* data is available to read...

This reduces failure rate from 10% to 3.5% on my setup.


Diffs
-----

  kpty/tests/kptyprocesstest.cpp b95ae26 

Diff: http://git.reviewboard.kde.org/r/108385/diff/


Testing
-------


Thanks,

Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130113/15397d61/attachment.html>


More information about the Kde-frameworks-devel mailing list