Review Request 107688: [PATCH 2/4] kcalendarsystem: Simplify the dayOfWeek() implementation.

[Jon Severinsson]

> On Jan. 13, 2013, 11:03 a.m., David Faure wrote:
> > kdecore/date/kcalendarsystem.h, line 631
> > <http://git.reviewboard.kde.org/r/107688/diff/2/?file=105846#file105846line631>
> >
> >     If this method is always equal to QDate::dayOfWeek(), shouldn't it be deprecated? Or is the idea that KCalendarSystem might one day support a type of calendar that QDate won't support?
> >     (I thought the long term plan was to have all of this in Qt though...)

It's mostly to match daysInWeek(), which becomes quite useless without a dayOfWeek() as well.

In my opinion both could be deprecated, but John Layt opposed that as it would prevent our ability to support odd calendar systems in the future.


- Jon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107688/#review25348
-----------------------------------------------------------


On Jan. 8, 2013, 3:40 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107688/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 3:40 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Day of week is the same for a given julian day number regardless of calendar system used.
> 
> 
> Diffs
> -----
> 
>   kdecore/date/kcalendarsystem.h efddd08 
>   kdecore/date/kcalendarsystem.cpp 198a863 
>   kdecore/date/kcalendarsystemgregorian.cpp 663cd1b 
>   kdecore/date/kcalendarsystemgregorian_p.h 6ba9088 
>   kdecore/date/kcalendarsystemhebrew.cpp fd66fa2 
>   kdecore/date/kcalendarsystemhebrew_p.h 75a6280 
> 
> Diff: http://git.reviewboard.kde.org/r/107688/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130113/c7273f02/attachment.html>