Review Request: [PATCH 4/4] kcalendarsystem: Simplify weekday naming a lot.

[Jon Severinsson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107696/
-----------------------------------------------------------

(Updated Jan. 8, 2013, 3:40 p.m.)


Review request for KDE Frameworks.


Changes
-------

Rebased the series on top of review #108263


Description (updated)
-------

Weekday names depend on *language*, not calendar system. The usual ki18nc
can handle it just fine, so consolidate it all to a single function.

Note: Between patch 3 and 4 in this series I'm moving some functions to a new file "kcalendarsystemweek.cpp" in order move to out ouf the way of regular calendar system code. That commit changes no code whatsoever, so don't really need a review.


Diffs (updated)
-----

  kdecore/date/kcalendarsystem.h efddd08 
  kdecore/date/kcalendarsystem.cpp 198a863 
  kdecore/date/kcalendarsystemcoptic.cpp 43d2611 
  kdecore/date/kcalendarsystemcoptic_p.h 5287271 
  kdecore/date/kcalendarsystemcopticprivate_p.h 35907ff 
  kdecore/date/kcalendarsystemethiopian.cpp 9bfc41f 
  kdecore/date/kcalendarsystemethiopian_p.h 4f8119e 
  kdecore/date/kcalendarsystemgregorian.cpp 663cd1b 
  kdecore/date/kcalendarsystemgregorian_p.h 6ba9088 
  kdecore/date/kcalendarsystemgregorianprivate_p.h fb7a0dd 
  kdecore/date/kcalendarsystemhebrew.cpp fd66fa2 
  kdecore/date/kcalendarsystemhebrew_p.h 75a6280 
  kdecore/date/kcalendarsystemindiannational.cpp 2cbfe23 
  kdecore/date/kcalendarsystemindiannational_p.h 499d2fa 
  kdecore/date/kcalendarsystemislamiccivil.cpp 774e081 
  kdecore/date/kcalendarsystemislamiccivil_p.h 6d4682f 
  kdecore/date/kcalendarsystemjalali.cpp 486ef16 
  kdecore/date/kcalendarsystemjalali_p.h c88d304 
  kdecore/date/kcalendarsystemjapanese.cpp d8a870b 
  kdecore/date/kcalendarsystemjapanese_p.h 09bb4f4 
  kdecore/date/kcalendarsystemjulian.cpp 23988e8 
  kdecore/date/kcalendarsystemjulian_p.h 5940c27 
  kdecore/date/kcalendarsystemminguo.cpp 449d103 
  kdecore/date/kcalendarsystemminguo_p.h 0a3b5d7 
  kdecore/date/kcalendarsystemprivate_p.h d935ead 
  kdecore/date/kcalendarsystemweek.cpp PRE-CREATION 
  kdecore/tests/kcalendartest.h 505c137 
  kdecore/tests/kcalendartest.cpp c607720 

Diff: http://git.reviewboard.kde.org/r/107696/diff/


Testing
-------


Thanks,

Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130108/152cc160/attachment.html>