Review Request: [PATCH 2/4] kcalendarsystem: Simplify the dayOfWeek() implementation.

[Jon Severinsson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107688/
-----------------------------------------------------------

(Updated Jan. 8, 2013, 3:40 p.m.)


Review request for KDE Frameworks.


Changes
-------

Rebased the series on top of review #108263
Un-inline dayOfWeek(), but still centralized and simplified its implementation.
That way we get most of the code simplifications without making future changes impossible.


Description
-------

Day of week is the same for a given julian day number regardless of calendar system used.


Diffs (updated)
-----

  kdecore/date/kcalendarsystem.h efddd08 
  kdecore/date/kcalendarsystem.cpp 198a863 
  kdecore/date/kcalendarsystemgregorian.cpp 663cd1b 
  kdecore/date/kcalendarsystemgregorian_p.h 6ba9088 
  kdecore/date/kcalendarsystemhebrew.cpp fd66fa2 
  kdecore/date/kcalendarsystemhebrew_p.h 75a6280 

Diff: http://git.reviewboard.kde.org/r/107688/diff/


Testing
-------


Thanks,

Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130108/443d73b0/attachment.html>