Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel

Kevin Ottens ervin at kde.org
Wed Feb 27 20:56:03 UTC 2013


On Wednesday 27 February 2013 19:22:18 Valentin Rusu wrote:
> > On Feb. 27, 2013, 7:11 p.m., Kevin Ottens wrote:
> > > kdeui/actions/kaction.cpp, line 77
> > > <http://git.reviewboard.kde.org/r/109019/diff/6/?file=116169#file116169l
> > > ine77>> > 
> > >     Please put the space before * and &, not after.
> 
> Old habits. However, watching code around this I see I'm not alone ;-)

Yeah, kdelibs is very inconsistent for historical reasons, but we're trying to 
improve that over time that's why I'm a bit picky on new code. ;-)

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130227/12d28ca3/attachment.sig>


More information about the Kde-frameworks-devel mailing list