Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel
Valentin Rusu
kde at rusu.info
Tue Feb 26 19:28:57 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109019/
-----------------------------------------------------------
(Updated Feb. 26, 2013, 7:28 p.m.)
Review request for KDE Frameworks, David Faure and Kevin Ottens.
Changes
-------
NP for this Kevin. Here is the updated diff.
Description
-------
KDELibs cleanup task: move global shortcut facilities from KAction to KGlobalAccel. The second step, registering QActions instead of KActions, will be done after completing this review.
Diffs (updated)
-----
kdeui/shortcuts/kglobalaccel_p.h 04feaba
kdeui/shortcuts/kglobalaccel.cpp 36dbab7
kdeui/actions/kaction_p.h b50e678
kdeui/shortcuts/kglobalaccel.h ed68bba
kdeui/actions/kaction.cpp ec63a72
KDE5PORTING.html e1b41d1
kdeui/actions/kaction.h ddaa4de
Diff: http://git.reviewboard.kde.org/r/109019/diff/
Testing
-------
Code compiles
Thanks,
Valentin Rusu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130226/9d33288c/attachment.html>
More information about the Kde-frameworks-devel
mailing list