Review Request 109019: Move global shortcut facilities from KAction to KGlobalAccel
Valentin Rusu
kde at rusu.info
Fri Feb 22 22:59:53 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109019/
-----------------------------------------------------------
(Updated Feb. 22, 2013, 10:59 p.m.)
Review request for KDE Frameworks, David Faure and Kevin Ottens.
Changes
-------
Here is the new patch, now with updated apidox and porting information :-)
Description
-------
KDELibs cleanup task: move global shortcut facilities from KAction to KGlobalAccel. The second step, registering QActions instead of KActions, will be done after completing this review.
Diffs (updated)
-----
KDE5PORTING.html e1b41d1
kdeui/actions/kaction.h ddaa4de
kdeui/actions/kaction.cpp ec63a72
kdeui/actions/kaction_p.h b50e678
kdeui/shortcuts/kglobalaccel.h ed68bba
kdeui/shortcuts/kglobalaccel.cpp 36dbab7
kdeui/shortcuts/kglobalaccel_p.h 04feaba
Diff: http://git.reviewboard.kde.org/r/109019/diff/
Testing
-------
Code compiles
Thanks,
Valentin Rusu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130222/720bd4f2/attachment.html>
More information about the Kde-frameworks-devel
mailing list